Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider condition for group membership - take 2 #71

Merged
merged 1 commit into from
Feb 17, 2018
Merged

consider condition for group membership - take 2 #71

merged 1 commit into from
Feb 17, 2018

Conversation

dirk-thomas
Copy link
Contributor

@dirk-thomas dirk-thomas commented Feb 17, 2018 •
edited
Loading

Reapply #69.

Requires ament/ament_tools#178.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Feb 17, 2018
@dirk-thomas dirk-thomas self-assigned this Feb 17, 2018
@dirk-thomas
Copy link
Contributor Author

dirk-thomas commented Feb 17, 2018 •
edited by nuclearsandwich
Loading

Build Status has already passed the critical point the last iteration failed on.

@mikaelarguedas
Copy link
Contributor

Note: same follow-up patches will be needed on ros-infrastructure/catkin_pkg#197

@dirk-thomas dirk-thomas merged commit fe037b1 into master Feb 17, 2018
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Feb 17, 2018
@dirk-thomas dirk-thomas deleted the revert-70-revert-69-fix_group_membership branch February 17, 2018 18:14
@dirk-thomas dirk-thomas mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @mikaelarguedas