Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider condition for group membership - take 2 #71

Merged
merged 1 commit into from
Feb 17, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ament_package/group_dependency.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,7 @@ def evaluate_condition(self, context):
def extract_group_members(self, packages):
self.members = set()
for pkg in packages:
if self.name in [g.name for g in pkg.member_of_groups]:
for g in pkg.member_of_groups:
assert g.evaluated_condition is not None
if self.name in [g.name for g in pkg.member_of_groups if g.evaluated_condition]:
self.members.add(pkg.name)