Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support for parsing package format 3 #195

Closed
wants to merge 2 commits into from

Conversation

nuclearsandwich
Copy link
Contributor

🚧 WIP. Do not merge. 🚧

This PR adds the minimum changes necessary to run bloom, and soon the ROS 2 buildfarm supporting the package format 3 from in ros-infrastructure/rep#138

At the moment the goal of this branch is to successfully parse format 3 packages without errors and is not intended to intended to bring complete support for format 3.

@nuclearsandwich nuclearsandwich self-assigned this Dec 6, 2017
@nuclearsandwich
Copy link
Contributor Author

Now that the release crunch is over we can examine this in more detail.

Should catkin_pkg implement support for the draft format 3? If so, I can start updating this PR with changes backported from ament_package.

@dirk-thomas
Copy link
Member

Should catkin_pkg implement support for the draft format 3?

The goal of REP 149 is to allow a ROS package to be build with ROS 1 as well as ROS 2 from a single source. So yes, catkin_pkg as well as other tools in the ROS 1 toolchain should support format 3.

@tspicer01
Copy link

Do we have an ETA on when we may have this support ready?
We've just moved our ROS2 builds from beta3 to GA and some of our legacy tooling that we use for both ROS and ROS2 fail on the packages that have been moved to format3.

@dirk-thomas
Copy link
Member

Do we have an ETA on when we may have this support ready?

I have created #197 to implement full REP 149 support. In the current state it does successfully parse all manifest files of ROS 2. It doesn't utilize the new information yet though, e.g. group dependencies or dependency conditions.


I think we should keep this around since it was used to create the releases into ardent. It will be convenient for future patch releases to not require changing the process.

@dirk-thomas
Copy link
Member

@nuclearsandwich Can you please try if #197 is sufficient for releasing ROS 2 packages. If yes, this can be closed.

@nuclearsandwich
Copy link
Contributor Author

This PR is superceded by #197

@nuclearsandwich nuclearsandwich deleted the wip-package-format-3 branch January 5, 2018 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants