Use yarn's patch protocol to patch suncalc3 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this is merged I'll send a patch to suncalc3 with our changes. Edit: done in Hypnos3/suncalc3#12 |
|
Wow that is amazing. Love the clean approach! |
ThomDietrich
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Home Assistant / Lovelace Card Repository
Overview
This repo has a local copy of
suncalc3, with a few modifications. While this works, it is not explicit what did we change insuncalc3. Yarn provides a system for exactly this use case: patch protocol (basically it stores a diff that gets applied onyarn install).In this PR I've deleted our local copy of
suncalc3, and used to generate a patch that yarn will apply.Type of Change
Related Issues / Pull Requests
Related to #121
Additional Details
To generate the patch, I copypasted our local copy of
suncalc3/suncalc.jsinto the library and then generated the patch, so I'm pretty confident all changes are present in the diff file.