Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build #157

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix CI build #157

merged 1 commit into from
Nov 6, 2024

Conversation

scinos
Copy link
Collaborator

@scinos scinos commented Nov 6, 2024

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

At some point we merged an incomplete yarn.lock (likely in #155), causing CI to fail. This PR fixes it by committing the missing changes in yarn.lock

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Documentation update
  • Refactoring
  • Other (please describe):

@ThomDietrich ThomDietrich merged commit b1e4f3d into rejuvenate:main Nov 6, 2024
2 of 3 checks passed
@ThomDietrich
Copy link

ThomDietrich commented Nov 6, 2024

Just one issue left and it seems not directly related to your changes. Do you have an idea how to fix it?
Btw if you want, I would like to offer you the maintainer role for this repo?
https://github.com/rejuvenate/rejuvenate/blob/master/README.md

@scinos
Copy link
Collaborator Author

scinos commented Nov 6, 2024

Just one issue left and it seems not directly related to your changes. Do you have an idea how to fix it?

I'd need to investigate how the release process work. But my initial guess is this fails because we didn't update the version number in package.json (based on the log of the step "Run rymndhng/release-on-push-action@master").

Do you happen to know what's the release process for this package?

Btw if you want, I would like to offer you the maintainer role for this repo?

Sure! I'd love to help.

@ThomDietrich
Copy link

This issue might be related to my change here: https://github.com/rejuvenate/lovelace-horizon-card/pull/88/files but I do not see why.

The release process should be based on those labels I can assign to PRs: "norelease", "release:major", "release:minor", "release:patch". I assume the issue came up because I didn't add any of those labels to the PR. I would expect that to have the same effect as adding "norelease", which my PR #88 was supposed to ensure.

@scinos scinos deleted the fix-ci2 branch November 7, 2024 05:26
@scinos scinos mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants