Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Home Assistant / Lovelace Card Repository
Overview
I am using this project as a submodule of my own HomeAssistant dashboard (HomeBoard)
There is an issue with importing SunCalc with Vite, where because it's a CommonJS export within an IIFE, it doesn't get picked up and I get the following error:
Uncaught SyntaxError: The requested module '/lovelace-horizon-card/suncalc3/suncalc.js' does not provide an export named 'default'
I have updated this module to use ES module syntax, and that resolves the issue.
Type of Change
Checklist
Please ensure that you have completed the following tasks before submitting your pull request:
dev
branch (or another appropriate branch) and verified that they are working as expected.Related Issues / Pull Requests
Additional Details
Please provide any additional information that you feel is relevant to this pull request, such as screenshots, code snippets, or examples.