refactor: remove thumbnail for non-edX videos & allow removing fallback URLs

[bra-i-am]

Description

This PR aims to solve the issue #1016 by showing the thumbnail from the videoSettingsModal only when the Video ID is one given by edX according to this method

Additionally, this PR fixes a bug when trying to delete a Fallback videos URL:

How to test

Go to the course authoring, and access a unit of a course. Now create a video and follow this:

1. If in Video ID you insert a UUIDv4 like 235d2e0e-864d-4b00-906a-77555c72fbb6, then the Thumbnail feature will be shown

2. If you write any other thing in Video ID, the thumbnail will be hidden (it is not an edX video)
3. Now, if you add some Fallback video URLs, you should be able to delete them without any problems

[openedx-webhooks]

Thanks for the pull request, @bra-i-am!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[bradenmacdonald]

@bra-i-am it looks like we need you to sign a CLA, or update the records to show that you're covered under eduNEXT's CLA. Then we can review this fix. CC @mphilbrick211

[bra-i-am]

@bradenmacdonald I just read that if I belong to an organization I have to email [email protected]. I'll be doing so!

I'm awaiting your comments in any case. Thanks a lot!

[bra-i-am]

@bradenmacdonald I'm already part of the edunext's CLA 🥳
I'll be waiting for the execution of the workflows so (if needed) I can apply corrections.

Thanks and please let me know any comments you have

[bradenmacdonald]

@bra-i-am Workflows unblocked :)

[bra-i-am]

thanks @bradenmacdonald and the changes were applied, please re-run the workflows

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (735d978) to head (945b56d).
Report is 22 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
+ Coverage   92.22%   92.30%   +0.08%     
==========================================
  Files        1008     1013       +5     
  Lines       18514    18732     +218     
  Branches     3948     4006      +58     
==========================================
+ Hits        17074    17291     +217     
- Misses       1373     1375       +2     
+ Partials       67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bra-i-am]

@KristinAoki, I already addressed the changes requested. Thanks for your feedback!