fix: when deleting a fallback URL the app crashed

openedx · Sep 4, 2024 · b4393f8 · b4393f8
1 parent ebccde0
commit b4393f8
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/...ntainers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/hooks.jsx b/...ntainers/VideoEditor/components/VideoSettingsModal/components/VideoSourceWidget/hooks.jsx
@@ -39,8 +39,16 @@ export const sourceHooks = ({ dispatch, previousVideoId, setAlert }) => ({
 
 export const fallbackHooks = ({ fallbackVideos, dispatch }) => ({
   addFallbackVideo: () => dispatch(actions.video.updateField({ fallbackVideos: [...fallbackVideos, ''] })),
+  /**
+   * Deletes the first occurrence of the given videoUrl from the fallbackVideos list
+   * @param {string} videoUrl - the video URL to delete
+   */
   deleteFallbackVideo: (videoUrl) => {
-    const updatedFallbackVideos = fallbackVideos.splice(fallbackVideos.indexOf(videoUrl), 1);
+    const index = fallbackVideos.findIndex(video => video === videoUrl);
+    const updatedFallbackVideos = [
+      ...fallbackVideos.slice(0, index),
+      ...fallbackVideos.slice(index + 1),
+    ];
     dispatch(actions.video.updateField({ fallbackVideos: updatedFallbackVideos }));
   },
 });