Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video player - contains an edx-specific workflow #1016

Closed
jmakowski1123 opened this issue May 17, 2024 · 5 comments
Closed

Video player - contains an edx-specific workflow #1016

jmakowski1123 opened this issue May 17, 2024 · 5 comments
Labels
release testing Affects the upcoming release (attention needed)

Comments

@jmakowski1123
Copy link

Video thumbnail feature only works with courses on the edx platform.

Can this feature be hidden/toggled off for the community release?

Screen Shot 2024-05-17 at 8 09 52 AM
@jmakowski1123 jmakowski1123 added the release testing Affects the upcoming release (attention needed) label May 17, 2024
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Aug 23, 2024

FYI @brian-smith-tcril @arbrandes

I'll try to get someone from my team to take a look. Thanks!

@bra-i-am
Copy link
Contributor

bra-i-am commented Aug 27, 2024

hi everyone,

I was looking at this issue and discovered that the component that needs to be modified to achieve the expected behavior belongs to @edx/frontend-lib-content-component right at this line.

I'll work on this and provide any updates here :3

@bra-i-am
Copy link
Contributor

I created a merge request: openedx/frontend-lib-content-components#505 to address this issue and a little bug I found during the working process. Please take a look and let me know anything

@bra-i-am
Copy link
Contributor

Due to openedx/frontend-lib-content-components was moved to be part of Course Authoring code, the merge request for addressing this issue and the bug changed to #1241

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Oct 9, 2024

Thank you for the fix, @bra-i-am. Since frontend-lib-content-components was archived, I won't push to include this fix in redwood. We'll keep an eye on it for Sumac, though.

I'll be closing this for now. cc @jmakowski1123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed)
Projects
Development

No branches or pull requests

3 participants