-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indy module migration #11457
Comments
This was referenced Jun 10, 2024
Because the migration will take a while, I have documented the migration and some of the characteristics of the non-inlined advices in #11546 The summary is:
Once everything has been migrated, this issue can be closed and we can start the next steps which might look like the following (to be further discussed):
|
This was referenced Jun 13, 2024
Merged
Merged
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following instrumentation modules currently override the
io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule#isIndyModule
and returnfalse
.Each of them will need to be modified in order to become "indy compliant".
This is part of #8999
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
The #9508 PR provides a list of reasons why those instrumentations need to be manually modified, for reference this #9508 PR is also the one that introduced a toggle to test this dispatch implementation through modification of advice classes.
The PRs that are tagged "test indy" (list) will run with this automatic migration to "indy dispatch".
The automatic transformation is provided by
io.opentelemetry.javaagent.tooling.instrumentation.indy.AdviceTransformer
ASM transformer.Implementation proposal
This issue gather the steps to complete the 1st step of this "simple but tedious" plan:
AdviceTransformer
AdviceTransformer
and cleanupThe text was updated successfully, but these errors were encountered: