Influxdb indy support

[LikeTheSalad]

Part of: #11457

These changes replace the use of @Adive.Locals and readOnly = false to make this instrumentation indy compatible.

There are a couple of extra changes brought from this other PR that allow instrumentations already using @Advice.AssignReturned.* annotations to work well.

[laurit]

would it make sense to return null instead when we didn't start a span from the enter advice? Idk whether this is ok or gets a NPE that is suppressed.

[LikeTheSalad]

I just changed it to returning null and it seems to be working fine 👍

[laurit]

In my opinion this is hard to follow. The size of the array could be either 1 or 2. If it is 2 then the last element is InfluxDbScope, if it is 1 then it is an object array. Perhaps it would be better to be more explicit.

if (enterArgs != null && enterArgs.length >= 2 && enterArgs[1] instanceof InfluxDbScope) {
  ((InfluxDbScope) enterArgs[1]).close(throwable);
}

instead of having a static InfluxDbScope.end() you could have an instance method. You don't need to pass instrumenter() to InfluxDbScope, it can call instrumenter() itself.

[LikeTheSalad]

Thanks, I've made the changes.

[laurit]

I think now we could return InfluxDbScope instead of Object

[LikeTheSalad]

Yes, I just made the change and it's working fine.

[laurit]

instead of having an if block that surrounds everything could extract the transform that changes the inline advice to delegating advice into helper method and call it here or perhaps even call it instead of instrument when only changing the advice type is desired

[LikeTheSalad]

Thanks, I've made the changes.