make netty-* indy compatible #11559

SylvainJuge · 2024-06-12T07:53:50Z

needs to have a common classloader for all netty instrumentation modules
is using @Advice.Local

Introduces NettyScope class to carry the state between enter and exit advice

"indy compatible" is defined in https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/11546/files#diff-c01c02c7d6cde11986ed4c95f749da6318b0deb89c371d866319371cc1757bd0

~~This PR needs to have the indy test label added for validation in CI.~~ Update: no longer necessary in CI

Local validation can be done with gradle test -PtestIndy=true

Update, also covers the following due to having to share the same CL

finagle
ratpack
spring cloud gateway

Documentation of all the changes have been added to the documentation PR: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/11546/files

…nstrumentation into indy-netty

…nReturned

…nstrumentation into indy-netty

...ng/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/TypeTransformerImpl.java

...a/io/opentelemetry/javaagent/instrumentation/netty/v4/common/NettyFutureInstrumentation.java

...y/javaagent/instrumentation/netty/v4/common/AbstractNettyChannelPipelineInstrumentation.java

.../java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/NettyChannelInstrumentation.java

…nstrumentation into indy-netty

...ntelemetry/javaagent/instrumentation/finaglehttp/v23_11/ChannelTransportInstrumentation.java

.../opentelemetry/javaagent/instrumentation/netty/v4_1/NettyChannelPipelineInstrumentation.java

…nstrumentation into indy-netty

...lemetry/javaagent/instrumentation/finaglehttp/v23_11/H2StreamChannelInitInstrumentation.java

…nstrumentation into indy-netty

...lemetry/javaagent/instrumentation/finaglehttp/v23_11/H2StreamChannelInitInstrumentation.java

...ry/javaagent/instrumentation/finaglehttp/v23_11/LocalSchedulerActivationInstrumentation.java

...ntelemetry/javaagent/instrumentation/finaglehttp/v23_11/PromiseMonitoredInstrumentation.java

...y/javaagent/instrumentation/netty/v4/common/AbstractNettyChannelPipelineInstrumentation.java

...a/io/opentelemetry/javaagent/instrumentation/netty/v4/common/NettyFutureInstrumentation.java

...ain/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/BootstrapInstrumentation.java

…nstrumentation into indy-netty

...y/javaagent/instrumentation/netty/v4/common/AbstractNettyChannelPipelineInstrumentation.java

...telemetry/javaagent/instrumentation/finaglehttp/v23_11/FinagleHttpInstrumentationModule.java

…nstrumentation into indy-netty

trask

last couple of comment suggestions

...y/javaagent/instrumentation/netty/v4/common/AbstractNettyChannelPipelineInstrumentation.java

...a/io/opentelemetry/javaagent/instrumentation/netty/v4/common/NettyFutureInstrumentation.java

Co-authored-by: Trask Stalnaker <[email protected]>

@test

* chore(deps): update gradle/actions action to v3.4.2 (main) (open-telemetry#11598) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Bump version in api diff compare (open-telemetry#11615) * chore(deps): update graalvm/setup-graalvm action to v1.2.2 (main) (open-telemetry#11624) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Simplify jetty9 http client instrumentation (open-telemetry#11595) * Merge change log updates from release/v1.33.x (open-telemetry#11628) * fix(deps): update quarkus packages to v3.11.3 (main) (patch) (open-telemetry#11629) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * remove conditional indy test in CI (open-telemetry#11631) * make aws-sdk indy compatible (open-telemetry#11552) * fix(deps): update quarkus packages to v3.12.0 (main) (minor) (open-telemetry#11630) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove aws sqs latest dep limit (open-telemetry#11643) * Fix deprecation warning in build script (open-telemetry#11642) * fix(deps): update dependency org.springframework.boot:spring-boot-starter-web to v3.3.1 (main) (open-telemetry#11644) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * re-use logic for http client configuration (open-telemetry#11620) Co-authored-by: Trask Stalnaker <[email protected]> * fix link (open-telemetry#11656) * fix(deps): update dependency net.ltgt.gradle:gradle-errorprone-plugin to v4.0.1 (main) (open-telemetry#11652) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Influxdb client: don't fill db.statement for create/drop database and write operations (open-telemetry#11557) * Update docs for bundled exporters (open-telemetry#11662) * Improve test error report (open-telemetry#11664) * Use more @ConditionalOnEnabledInstrumentation (open-telemetry#11665) * Fix typo (open-telemetry#11672) * Remove reflection from builder (open-telemetry#11673) * fix(deps): update junit5 monorepo to v5.10.3 (main) (patch) (open-telemetry#11681) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * don't use test keystore for vaadin (open-telemetry#11679) * Add address and port assertions (open-telemetry#11668) * Update http metrics to the latest version (open-telemetry#11659) * fix(deps): update armeria packages to v1.29.1 (main) (patch) (open-telemetry#11686) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency io.grpc:grpc-bom to v1.65.0 (main) (open-telemetry#11689) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix running ./gradlew tasks (open-telemetry#11692) * chore(deps): update github/codeql-action action to v3.25.11 (main) (open-telemetry#11699) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update groovy monorepo (main) (patch) (open-telemetry#11706) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix build for graalvm native (open-telemetry#11709) * add javalin instrumentation (open-telemetry#11587) * fix(deps): update dependency io.opentelemetry.proto:opentelemetry-proto to v1.3.2-alpha (main) (open-telemetry#11715) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix kafka graalvm native (open-telemetry#11714) * cleanup log filter (open-telemetry#11719) * fix(deps): update dependency org.owasp:dependency-check-gradle to v10 (main) (open-telemetry#11720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * config properties support for spring starter clients (open-telemetry#11605) * fix(deps): update dependency org.owasp:dependency-check-gradle to v10.0.1 (main) (open-telemetry#11722) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * rebuild when labels change, so that we can trigger the right actions (open-telemetry#11725) * Add GraalVM Kafka hints (open-telemetry#11735) * Fix collector conf for overhead tests (open-telemetry#11730) * fix(deps): update quarkus packages to v3.12.1 (main) (patch) (open-telemetry#11732) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Convert jsf jakarta tests from groovy to java (open-telemetry#11694) * Fix GraalVM hint (open-telemetry#11737) * Jsf: simplify asserting exception (open-telemetry#11736) * Convert jsf javax tests from groovy to java (open-telemetry#11711) * fix(deps): update dependency commons-logging:commons-logging to v1.3.3 (main) (open-telemetry#11740) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.codehaus.mojo:animal-sniffer-annotations to v1.24 (main) (open-telemetry#11741) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Replace junit4 @test annotation with junit5 annotation (open-telemetry#11745) * chore(deps): update actions/upload-artifact action to v4.3.4 (main) (open-telemetry#11748) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update jackson packages to v2.17.2 (main) (patch) (open-telemetry#11750) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * fix(deps): update dependency org.owasp:dependency-check-gradle to v10.0.2 (main) (open-telemetry#11753) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Exclude javalin 3.2.0 from muzzle (open-telemetry#11766) * Update the OpenTelemetry SDK version to 1.40.0 (open-telemetry#11752) Co-authored-by: Lauri Tulmin <[email protected]> * support otel.instrumentation.common.default-enabled in spring starter (open-telemetry#11746) * fix(deps): update dependency org.codenarc:codenarc to v3.5.0 (main) (open-telemetry#11758) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add link to SDK configuration page (open-telemetry#11729) * Build image for testing early jdk8 (open-telemetry#11594) * fix(deps): update byte buddy packages to v1.14.18 (main) (patch) (open-telemetry#11767) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Trask Stalnaker <[email protected]> * Support tracing the ClickHouse Java HTTP client (open-telemetry#11660) * support jettyclient 12 (open-telemetry#11519) Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]> * Fix build (open-telemetry#11776) * chore(deps): update gradle/actions action to v3.4.2 (main) (open-telemetry#11770) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Enable early jdk8 test (open-telemetry#11777) * Add Pulsar MessagingProducerMetrics (open-telemetry#11591) Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Steve Rao <[email protected]> * chore(deps): update actions/setup-node action to v4.0.3 (main) (open-telemetry#11780) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.assertj:assertj-core to v3.26.3 (main) (open-telemetry#11781) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix windows benchmark fail (open-telemetry#11698) * Alter instrumentation suppression behavior (open-telemetry#11640) * Propagate otel context through custom aws client context for lambda direct calls (open-telemetry#11675) Co-authored-by: Lauri Tulmin <[email protected]> * fix(deps): update armeria packages to v1.29.2 (main) (patch) (open-telemetry#11785) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency io.quarkus:quarkus-bom to v3.12.2 (main) (open-telemetry#11787) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin io.quarkus to v3.12.2 (main) (open-telemetry#11789) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Spring autoconf deps (open-telemetry#11784) * GraalVM native support for the OpenTelemetry annotations (open-telemetry#11757) Co-authored-by: Trask Stalnaker <[email protected]> * Use config properties for spring starter (http server) (open-telemetry#11667) Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]> * Update @EnableOpenTelemetry javadoc (open-telemetry#11799) * chore(deps): update github/codeql-action action to v3.25.12 (main) (open-telemetry#11808) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency io.grpc:grpc-bom to v1.65.1 (main) (open-telemetry#11804) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dockerjavaversion to v3.4.0 (main) (minor) (open-telemetry#11802) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * rename spring autoconfigure to autoconfigure-2 (open-telemetry#11800) * make spring starter stable (open-telemetry#11763) * chore(deps): update dependency gradle to v8.9 (main) (open-telemetry#11798) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ubuntu docker tag to v24 (main) (open-telemetry#11771) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix http.server.active_requests metric with async requests (open-telemetry#11638) Co-authored-by: Helen <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]> * Rename spring-boot-autoconfigure artifacts (open-telemetry#11815) * fix(deps): update dependency org.owasp:dependency-check-gradle to v10.0.3 (main) (open-telemetry#11834) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency commons-codec:commons-codec to v1.17.1 (main) (open-telemetry#11830) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove unneeded groovy dependencies from lambda tests (open-telemetry#11828) * Restructure to have a single spring-boot-autoconfigure artifact (open-telemetry#11826) * chore(deps): update gradle/actions action to v3.5.0 (main) (open-telemetry#11824) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update change log for v2.6.0 release (open-telemetry#11816) * Update version to 2.7.0-SNAPSHOT (open-telemetry#11839) Co-authored-by: Trask Stalnaker <[email protected]> * fix(deps): update testcontainers-java monorepo to v1.20.0 (main) (minor) (open-telemetry#11846) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update quarkus packages to v3.12.3 (main) (patch) (open-telemetry#11842) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Merge change log updates from release/v2.6.x (open-telemetry#11840) * Update api diff after release (open-telemetry#11850) * Add span baggage processor (open-telemetry#11697) * Fix ClickHouse tracing when database name not included in connection string (open-telemetry#11852) * fix(deps): update dependency io.netty:netty-bom to v4.1.112.final (main) (open-telemetry#11864) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update github/codeql-action action to v3.25.13 (main) (open-telemetry#11862) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.springframework.boot:spring-boot-starter-web to v3.3.2 (main) (open-telemetry#11855) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update errorproneversion to v2.29.2 (main) (minor) (open-telemetry#11836) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update bellsoft/liberica-openjdk-alpine docker tag to v21.0.4 (main) (open-telemetry#11863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.apache.commons:commons-lang3 to v3.15.0 (main) (open-telemetry#11848) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.gradle.develocity:com.gradle.develocity.gradle.plugin to v3.17.6 (main) (open-telemetry#11875) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin com.gradle.develocity to v3.17.6 (main) (open-telemetry#11874) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update docker/login-action action to v3.3.0 (main) (open-telemetry#11877) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Consolidate github action renovate PRs (open-telemetry#11829) * Reformat supported libraries doc (open-telemetry#11889) * fix(deps): update quarkus packages to v3.13.0 (main) (minor) (open-telemetry#11894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.google.protobuf:protobuf-java-util to v3.25.4 (main) (open-telemetry#11897) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix missing throw statement in RestClientWrapper (open-telemetry#11892) (open-telemetry#11893) * Merge change log updates from release/v1.33.x (open-telemetry#11904) * fix(deps): update armeria packages to v1.29.3 (main) (patch) (open-telemetry#11906) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update github actions (main) (open-telemetry#11910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.uber.nullaway:nullaway to v0.11.1 (main) (open-telemetry#11916) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update armeria packages to v1.29.4 (main) (patch) (open-telemetry#11923) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix latest dep tests (open-telemetry#11925) * Convert jsp 2.3 tests from groovy to java (open-telemetry#11827) * fix(deps): update testcontainers-java monorepo to v1.20.1 (main) (patch) (open-telemetry#11931) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix broken link (open-telemetry#11935) * Allow any types in invokedynamic advice method signatures (open-telemetry#11873) Co-authored-by: Lauri Tulmin <[email protected]> * Improve tomcat version detection (open-telemetry#11936) * Add @jaydeluca as triager (open-telemetry#11937) * Update kafka docker image (open-telemetry#11938) * chore(deps): update actions/upload-artifact action to v4.3.5 (main) (open-telemetry#11943) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix class cast exception, noop meter does not implement incubating api (open-telemetry#11934) * Executors indy support (open-telemetry#11738) * idempotent license report (open-telemetry#11810) Co-authored-by: Lauri Tulmin <[email protected]> * chore(deps): update plugin org.jetbrains.kotlin.jvm to v2.0.10 (main) (open-telemetry#11955) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update slf4j monorepo to v2.0.14 (main) (patch) (open-telemetry#11957) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * fix(deps): update dependency org.awaitility:awaitility to v4.2.2 (main) (open-telemetry#11960) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency io.quarkus:quarkus-bom to v3.13.1 (main) (open-telemetry#11962) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin io.quarkus to v3.13.1 (main) (open-telemetry#11966) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency org.apache.commons:commons-lang3 to v3.16.0 (main) (open-telemetry#11967) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency io.grpc:grpc-bom to v1.66.0 (main) (open-telemetry#11972) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update slf4j monorepo to v2.0.15 (main) (patch) (open-telemetry#11976) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * Update shadow plugin to new version and coordinates (open-telemetry#11979) * Improve akka route handling with java dsl (open-telemetry#11926) * fix(deps): update dependency org.slf4j:slf4j-simple to v2.0.15 (main) (open-telemetry#11981) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Ignore alibaba fastjson ASMClassLoader (open-telemetry#11954) * fix(deps): update quarkus packages to v3.13.2 (main) (patch) (open-telemetry#11983) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Convert cdi-testing test from groovy to java (open-telemetry#11982) * fix(deps): update slf4j monorepo to v2.0.16 (main) (patch) (open-telemetry#11989) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * chore(deps): update github actions (main) (open-telemetry#11995) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update gradle/actions action to v4 (main) (open-telemetry#11996) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update errorproneversion to v2.30.0 (main) (minor) (open-telemetry#11991) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * Use `aws-lambda-java-serialization` library, which is available by default, while deserializing input and serializing output (open-telemetry#11868) * fix(deps): update armeria packages to v1.30.0 (main) (minor) (open-telemetry#12001) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Influxdb indy support (open-telemetry#11710) Co-authored-by: Jonas Kunz <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> * Force dynamic typing on AssignReturned annotations (open-telemetry#11884) * Update the OpenTelemetry SDK version to 1.41.0 (open-telemetry#11985) Co-authored-by: Lauri Tulmin <[email protected]> * Fix building wildfly docker image (open-telemetry#11998) * Add assert inverse to ktor2 muzzle configuration (open-telemetry#11948) * chore(deps): update dependency gradle to v8.10 (main) (open-telemetry#12014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Closing a kafka producer/consumer should not disable metrics from other consumers/producers (open-telemetry#11975) * Logback appender: map timestamp in nanoseconds if possible (open-telemetry#11807) (open-telemetry#11974) * Save ILoggingEvent.getArgumentArray() arguments from Logback (open-telemetry#11865) Co-authored-by: Lauri Tulmin <[email protected]> * use DefaultHttpClientInstrumenterBuilder and DefaultHttpServerInstrumenterBuilder for armeria (open-telemetry#11797) Co-authored-by: Trask Stalnaker <[email protected]> * Fix ending span in Ktor plugin (open-telemetry#11726) * Use stable semconv for Java17 (open-telemetry#11914) Co-authored-by: Lauri Tulmin <[email protected]> * fix(deps): update dependency commons-cli:commons-cli to v1.9.0 (main) (open-telemetry#12017) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Limit vaadin 14 latest dep version (open-telemetry#12025) * Add Pulsar Consumer metrics (open-telemetry#11891) Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Steve Rao <[email protected]> * Fix logback appender test (open-telemetry#12027) * fix(deps): update junit5 monorepo to v5.11.0 (main) (minor) (open-telemetry#12010) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.7 (main) (open-telemetry#12029) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin com.github.jk1.dependency-license-report to v2.9 (main) (open-telemetry#12030) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix netty memory leak (open-telemetry#12003) * Update change log (open-telemetry#12019) * fix(deps): update byte buddy packages to v1.14.19 (main) (patch) (open-telemetry#12033) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Trask Stalnaker <[email protected]> * Update version to 2.8.0-SNAPSHOT (open-telemetry#12037) Co-authored-by: Lauri Tulmin <[email protected]> * Update api diffs (open-telemetry#12045) * chore(deps): update github/codeql-action action to v3.26.2 (main) (open-telemetry#12047) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update guava packages to v33.3.0-jre (main) (minor) (open-telemetry#12040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.gradle.develocity:com.gradle.develocity.gradle.plugin to v3.18 (main) (open-telemetry#12051) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin com.gradle.develocity to v3.18 (main) (open-telemetry#12050) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency commons-logging:commons-logging to v1.3.4 (main) (open-telemetry#12053) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.uber.nullaway:nullaway to v0.11.2 (main) (open-telemetry#12057) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Try to fix disabling renovate updates for spring boot (open-telemetry#12059) * [improve][pulsar] Enhance SendCallback to address PIP-363 (open-telemetry#11648) Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> * Delay loading `InetAddressResolverProvider` until after the agent has started (open-telemetry#11987) Co-authored-by: Lauri Tulmin <[email protected]> * Remove unused renovate config (open-telemetry#12060) * fix(deps): update quarkus packages to v3.13.3 (main) (patch) (open-telemetry#12067) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update otelcontribversion to v1.38.0-alpha (main) (minor) (open-telemetry#12061) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * Fix instrumentation for the latest version of ucp (open-telemetry#12052) * JdbcIgnoredTypesConfigurer support Shardingsphere 5.x (open-telemetry#12066) * fix(deps): update quarkus packages to v3.14.0 (main) (minor) (open-telemetry#12074) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * enforce static imports (open-telemetry#12009) * chore(deps): update plugin org.jetbrains.kotlin.jvm to v2.0.20 (main) (open-telemetry#12081) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * make netty-* indy compatible (open-telemetry#11559) Co-authored-by: Jonas Kunz <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]> * make hibernate-* indy compatible (open-telemetry#11553) * fix(deps): update dependency org.springframework.boot:spring-boot-starter-web to v3.3.3 (main) (open-telemetry#12087) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update github/codeql-action action to v3.26.5 (main) (open-telemetry#12105) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency checkstyle to v10.18.0 (main) (open-telemetry#12103) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add workflow to complete 1.33.6 to main (open-telemetry#12107) * fix(deps): update byte buddy packages to v1.15.0 (main) (minor) (open-telemetry#12094) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * Fix rabbitmq NullPointerException (open-telemetry#12109) * Merge change log updates from release/v1.33.x (open-telemetry#12114) * Remove temporary workflow (open-telemetry#12115) * Name is not needed for annotation value parameter (open-telemetry#12113) * Convert apache-httpclient-2.0 tests from groovy to java (open-telemetry#12102) Co-authored-by: Steve Rao <[email protected]> * convert spring integration tests to java (open-telemetry#11999) Co-authored-by: Jay DeLuca <[email protected]> * Add network peer address attributes to the span for the `okhttp-3.0` instrumentation (open-telemetry#12012) * Add support for cxf 4.0 jaxws (open-telemetry#12077) * fix(deps): update dependency org.mockito:mockito-core to v5.13.0 (main) (open-telemetry#12123) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update quarkus packages to v3.14.1 (main) (patch) (open-telemetry#12129) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * indy advice docs & migration procedure (open-telemetry#11546) * fix(deps): update errorproneversion to v2.31.0 (main) (minor) (open-telemetry#12134) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update units of time based metrics from millis to seconds for Java17 … (open-telemetry#12084) * Added rules for capturing Apache Camel metrics exposed by JMX MBeans (open-telemetry#11901) * Fix play-mvc\methods NullPointerException (open-telemetry#12121) * Spring batch tests to java - basic (open-telemetry#12076) * chore(deps): update plugin com.gradle.plugin-publish to v1.2.2 (main) (open-telemetry#12137) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Pin github actions by hash (open-telemetry#12140) * fix(deps): update dependency org.apache.commons:commons-lang3 to v3.17.0 (main) (open-telemetry#12145) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency checkstyle to v10.18.1 (main) (open-telemetry#12150) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update byte buddy packages to v1.15.1 (main) (patch) (open-telemetry#12141) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lauri Tulmin <[email protected]> * fix(deps): update dependency org.owasp:dependency-check-gradle to v10.0.4 (main) (open-telemetry#12152) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update github actions (main) (open-telemetry#12155) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix error span status for successful requests in Ktor (open-telemetry#12161) * Convert opentelemetry-api-1.0 tests from groovy to java (open-telemetry#12133) Co-authored-by: Lauri Tulmin <[email protected]> * convert module apache-dubbo-2.7 test case from groovy to java (open-telemetry#12008) Co-authored-by: Jay DeLuca <[email protected]> * Test whether http client span ends after headers or body is received (open-telemetry#12149) * Remove unused imports (open-telemetry#12165) * Keep junit extensions in static fields (open-telemetry#12166) * fix(deps): update dependency io.netty:netty-bom to v4.1.113.final (main) (open-telemetry#12169) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update quarkus packages to v3.14.2 (main) (patch) (open-telemetry#12167) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * make internal-reflection indy compatible (open-telemetry#12136) Co-authored-by: Jonas Kunz <[email protected]> * Make OpenTelemetry-API Bridge and dependent instrumentations work with indy (open-telemetry#11578) * Make log record asserts similar to trace asserts (open-telemetry#12164) * Enable tests for jedis 2.7.2 (open-telemetry#12175) * Add empty line to separate blocks (open-telemetry#12174) * Fix flaky spring integration test (open-telemetry#12185) * Read timeout in jetty http client tests (open-telemetry#12184) * Make rocketmq span status extractor delegate to default extractor (open-telemetry#12183) * Remove unneeded span status extractor (open-telemetry#12182) * fix(deps): update dependency org.apache.logging.log4j:log4j-bom to v2.24.0 (main) (open-telemetry#12187) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency ch.qos.logback:logback-classic to v1.5.8 (main) (open-telemetry#12189) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency gradle to v8.10.1 (main) (open-telemetry#12191) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin org.graalvm.buildtools.native to v0.10.3 (main) (open-telemetry#12205) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin com.gradleup.shadow to v8.3.1 (main) (open-telemetry#12208) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.gradleup.shadow:shadow-gradle-plugin to v8.3.1 (main) (open-telemetry#12209) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update plugin com.gradle.develocity to v3.18.1 (main) (open-telemetry#12211) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency com.gradle.develocity:com.gradle.develocity.gradle.plugin to v3.18.1 (main) (open-telemetry#12212) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * updating .gitignore to ignore workflows except the middleware one * test fix, and reverted to grpc as default otel protocol * Added feature flag for continuous profiling --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: SylvainJuge <[email protected]> Co-authored-by: Gregor Zeitlinger <[email protected]> Co-authored-by: Jay DeLuca <[email protected]> Co-authored-by: Jean Bisutti <[email protected]> Co-authored-by: crossoverJie <[email protected]> Co-authored-by: Lucas Amoroso <[email protected]> Co-authored-by: Liu Ziming <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]> Co-authored-by: Steve Rao <[email protected]> Co-authored-by: John Bley <[email protected]> Co-authored-by: Helen <[email protected]> Co-authored-by: kyy1996 <[email protected]> Co-authored-by: Jonas Kunz <[email protected]> Co-authored-by: César <[email protected]> Co-authored-by: jason plumb <[email protected]> Co-authored-by: Serkan ÖZAL <[email protected]> Co-authored-by: Jérôme Joslet <[email protected]> Co-authored-by: Igor Suhorukov <[email protected]> Co-authored-by: Mariia Skripchenko <[email protected]> Co-authored-by: Robert Niedziela <[email protected]> Co-authored-by: 道君 <[email protected]> Co-authored-by: Shelby Huang <[email protected]> Co-authored-by: xiepuhuan <[email protected]> Co-authored-by: Luigi De Masi <[email protected]> Co-authored-by: shalk(xiao kun) <[email protected]>

netty common classloader

80e04d3

This was referenced Jun 12, 2024

Indy module migration #11457

Open

indy advice docs & migration procedure #11546

Merged

SylvainJuge added a commit to SylvainJuge/opentelemetry-java-instrumentation that referenced this pull request Jun 12, 2024

move netty-* to open-telemetry#11559

ae87603

SylvainJuge added 8 commits June 12, 2024 11:00

introduce NettyScope for 4.x

b2d1c4c

refactor netty scope

6cf99fd

add NettyScope for 3.8

62745a9

make things private final

cefc148

return value

fd3e0c9

wip call depth

701caf0

read/write arguments

aba151e

wip but stil broken

1bc40a4

trask added the test indy label Jun 12, 2024

SylvainJuge and others added 14 commits June 13, 2024 12:02

fix typo

50b2f76

fix AssignReturned with non inlined advices

075fe14

restore working state + todos

df7c853

fix formatting

77e687a

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

4c3396f

…nstrumentation into indy-netty

wip

a72619f

return array when needed + note for investigation

e79ddbf

Prevent advice transformations on advices already using @Advice.Assig…

ec823b4

…nReturned

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

8ca0cad

…nstrumentation into indy-netty

spotless

29b2d9d

migrate finagle-http

95b0f59

spring cloud gateway + webflux

a210666

migrate ratpack

18a1c49

spotless

f6ff56d

SylvainJuge commented Jun 26, 2024

View reviewed changes

SylvainJuge marked this pull request as ready for review June 26, 2024 14:24

SylvainJuge requested a review from a team June 26, 2024 14:24

SylvainJuge requested review from JonasKunz and LikeTheSalad June 26, 2024 14:24

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

ee2ae1b

…nstrumentation into indy-netty

JonasKunz approved these changes Jul 1, 2024

View reviewed changes

add support for AssignReturned.ToAllArguments

06c90e4

LikeTheSalad approved these changes Jul 2, 2024

View reviewed changes

trask reviewed Jul 9, 2024

View reviewed changes

...ntelemetry/javaagent/instrumentation/finaglehttp/v23_11/ChannelTransportInstrumentation.java Outdated Show resolved Hide resolved

JonasKunz mentioned this pull request Jul 10, 2024

make hibernate-* indy compatible #11553

Merged

laurit reviewed Aug 13, 2024

View reviewed changes

.../opentelemetry/javaagent/instrumentation/netty/v4_1/NettyChannelPipelineInstrumentation.java Outdated Show resolved Hide resolved

SylvainJuge added 2 commits August 14, 2024 10:41

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

02c6a5b

…nstrumentation into indy-netty

simplify advices

10a3427

trask reviewed Aug 15, 2024

View reviewed changes

...lemetry/javaagent/instrumentation/finaglehttp/v23_11/H2StreamChannelInitInstrumentation.java Outdated Show resolved Hide resolved

SylvainJuge added 2 commits August 19, 2024 13:46

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

9acdd70

…nstrumentation into indy-netty

remove dynamic assigner when we can

f6d0233

trask reviewed Aug 19, 2024

View reviewed changes

SylvainJuge added 2 commits August 20, 2024 11:52

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

06e07dc

…nstrumentation into indy-netty

avoid Object in advice return value

b42189b

trask approved these changes Aug 20, 2024

View reviewed changes

...y/javaagent/instrumentation/netty/v4/common/AbstractNettyChannelPipelineInstrumentation.java Show resolved Hide resolved

...telemetry/javaagent/instrumentation/finaglehttp/v23_11/FinagleHttpInstrumentationModule.java Show resolved Hide resolved

SylvainJuge added 3 commits August 21, 2024 08:54

add comments from review

09e4d77

add todo

cb8c5b8

Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…

3da4520

…nstrumentation into indy-netty

trask approved these changes Aug 21, 2024

View reviewed changes

SylvainJuge and others added 2 commits August 22, 2024 14:22

Apply suggestions from code review

94f6a28

Co-authored-by: Trask Stalnaker <[email protected]>

add AsScalar comment

2777b30

trask merged commit d0d39b8 into open-telemetry:main Aug 22, 2024
56 checks passed

SylvainJuge deleted the indy-netty branch August 22, 2024 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make netty-* indy compatible #11559

make netty-* indy compatible #11559

SylvainJuge commented Jun 12, 2024 •

edited

Loading

trask left a comment

make netty-* indy compatible #11559

make netty-* indy compatible #11559

Conversation

SylvainJuge commented Jun 12, 2024 • edited Loading

trask left a comment

Choose a reason for hiding this comment

SylvainJuge commented Jun 12, 2024 •

edited

Loading