Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make internal-class-loader indy compatible #12195

Closed
wants to merge 10 commits into from

Conversation

SylvainJuge
Copy link
Contributor

Part of #11457

Migrates the internal/classloader module to be indy-compatible.

Also removes leftover usages of readOnly = false for return values on a few other modules:

  • internal/osgi
  • internal-reflection (integration tests)
  • internal/internal-url-class-loader (integration tests)

@SylvainJuge
Copy link
Contributor Author

There are a few extra challenges discovered while implementing this:

  • the initial migration went well, but did not work for indy 192137a
  • I had to work-around a bug when skipOn is used and advices do not return an array d40c2b3
  • classloader instrumentation had to be migrated to ASM because it triggered stack overflow or nested invokedynamic invocations (instrument loading classes while loading advices/helper is probably not a very good mix).

@SylvainJuge SylvainJuge mentioned this pull request Sep 13, 2024
36 tasks
@SylvainJuge
Copy link
Contributor Author

Closing in favor of #12242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant