Add github action to ensure build [VC2022] #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cielavenir
changed the title
This was referenced Dec 8, 2023
hemangandhi
reviewed
Apr 17, 2024
| cmake .. -G 'Visual Studio 17 2022' -A x64 -DRAPIDJSON_HAS_STDSTRING=ON -DRAPIDJSON_BUILD_DOC=OFF -DRAPIDJSON_BUILD_EXAMPLES=OFF -DRAPIDJSON_BUILD_TESTS=OFF | ||
| msbuild ALL_BUILD.vcxproj /p:Configuration=Release | ||
| cd ..\.. | ||
| - name: Install libzmq |
There was a problem hiding this comment.
If we're maintaining this approach, should we also get rid of the msvc_binaries?
| @@ -358,6 +358,7 @@ inline void LoadJsonValue(const rapidjson::Value& v, unsigned long long& t) { | |||
| } | |||
| } | |||
|
|
|||
| #ifndef _MSC_VER | |||
There was a problem hiding this comment.
Should we #include <stdint.h> instead? Based on https://stackoverflow.com/questions/13604137/definition-of-int64-t
There was a problem hiding this comment.
@hemangandhi The thing is, there exists a branch which supports VC2010 https://github.com/mujin/controllerclientcpp/tree/savebackup and VC2010 does not support <stdint.h>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember that controllerclientcpp is compatible with msvc. But how to maintain compatibility is unclear. Here we start to maintain it as code.