Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: set default geometry value #139

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

cielavenir
Copy link

@cielavenir cielavenir commented Aug 17, 2023

I found that webstack geometry API does not return "visible" field always, which has to be interpreted as true.

As C++ does not have None value, the value is undefined. I saw something like 106 or 112, random.

This is the cause of test_planningsystem test_ObjectVisible flakiness.

@woswos @lazydroid There might be some other fields which might need to be filled as well, could you check?

/cc @felixvd @ntohge

@cielavenir
Copy link
Author

@woswos @ziyan test_ObjectVisible firstly failed in pipelineid=379165 (Pipeline #601478). Do you know some background?

@cielavenir
Copy link
Author

Would need to ask for review from Yoshiki

@cielavenir cielavenir requested a review from felixvd December 8, 2023 02:23
@cielavenir
Copy link
Author

I want to improve this MR when I have time, but testing is tiresome, so I'm going to ensure building by #146 .

@cielavenir cielavenir requested a review from hemangandhi April 15, 2024 03:11
Copy link

@hemangandhi hemangandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/CMakeLists.txt Outdated Show resolved Hide resolved
src/mujincontrollerclient.cpp Outdated Show resolved Hide resolved
@cielavenir
Copy link
Author

@felixvd @hemangandhi could you check if there are missing header initialization than visible?

@cielavenir
Copy link
Author

it is almost 1 year.

now it is in hurry.

I filed document/team#193.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants