Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): add PR name substitution for scheduled runs. #1344

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Sep 7, 2023

Which issue is resolved by this Pull Request:
Resolves #1343

Description of your changes:
The change ensures instanes of ORIG_PR_NAME are properly substituted for scheduled runs, just like in manually triggered runs. It also adds the missing custom.tekton.dev/originalPipelineRun. Both cases are handled in SWF controller, since workflow names for recurring runs are generated there.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @HumairAK

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 79272ef into kubeflow:master Sep 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurring runs do not inherit Pipeline Run names and substitutions
2 participants