Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): add PR name substitution for scheduled runs. #125

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix(backend): add PR name substitution for scheduled runs. #125

merged 2 commits into from
Sep 12, 2023

Conversation

HumairAK
Copy link

@HumairAK HumairAK commented Sep 1, 2023 •
edited
Loading

Which issue is resolved by this Pull Request:
Resolves #124

Description of your changes:
Consume upstream changes from kfp/tekton:
kubeflow@6fc63c8

Also cherry picks: kubeflow#1344

SDK Changes are not included.

@HumairAK
feat(backend): Add metadata field to scheduled workflow
ee3cf4a 
Consume upstream changes from kfp/tekton:
kubeflow@6fc63c8

SDK Changes are not included.

Signed-off-by: Humair Khan <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 1, 2023
@HumairAK
Copy link
Author

HumairAK commented Sep 1, 2023

/hold

@HumairAK HumairAK marked this pull request as draft September 1, 2023 20:22
@HumairAK
Copy link
Author

HumairAK commented Sep 1, 2023 •
edited
Loading

seems like these changes don't account for the annotation:

custom.tekton.dev/originalPipelineRun
which we use to determine the location of artifacts for big data passing

image
on the left is a manually triggered run, on the right is the scheduled run

@HumairAK HumairAK mentioned this pull request Sep 5, 2023
Closed
1 task
@HumairAK HumairAK marked this pull request as ready for review September 7, 2023 20:32
@HumairAK HumairAK removed the request for review from harshad16 September 8, 2023 16:59
@HumairAK HumairAK added the qe/verify Labels to inform qe on issues to verify. label Sep 11, 2023
This was referenced Aug 24, 2023
Closed
Closed
gmfrasca
gmfrasca reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2023
@HumairAK HumairAK merged commit e8028bb into opendatahub-io:master Sep 12, 2023
10 of 13 checks passed
@HumairAK HumairAK mentioned this pull request Sep 18, 2023
Merged
@HumairAK HumairAK changed the title feat(backend): Add metadata field to scheduled workflow fix(backend): add PR name substitution for scheduled runs. Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmfrasca gmfrasca gmfrasca left review comments

@amadhusu amadhusu Awaiting requested review from amadhusu

@gregsheremeta gregsheremeta Awaiting requested review from gregsheremeta

Assignees

@gmfrasca gmfrasca

Labels
approved do-not-merge/hold lgtm qe/verify Labels to inform qe on issues to verify.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Scheduled Workflows Does not receive tekton annnotaions
2 participants
@HumairAK @gmfrasca