Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HumairAK as member to kubeflow org. #637

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Jan 5, 2024

Resolve: #636

Contributions:

pytest output:

(github-orgs) github-orgs (add_member)$ pytest test_org_yaml.py 
=================================================================================== test session starts ====================================================================================
platform linux -- Python 3.10.10, pytest-7.4.4, pluggy-1.3.0
rootdir: /home/hukhan/projects/github/kubeflow/internal-acls/github-orgs
collected 1 item                                                                                                                                                                           

test_org_yaml.py .                                                                                                                                                                   [100%]

==================================================================================== 1 passed in 0.11s =====================================================================================
(github-orgs) github-orgs (add_member)$ 

Copy link

Hi @HumairAK. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DharmitD
Copy link
Contributor

DharmitD commented Jan 5, 2024

/ok-to-test

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rimolive
Copy link
Member

rimolive commented Jan 5, 2024

+1

@rimolive
Copy link
Member

rimolive commented Jan 5, 2024

@chensun @zijianjoy Can you help us approve this?

@DharmitD
Copy link
Contributor

DharmitD commented Jan 5, 2024

+1

@terrytangyuan
Copy link
Member

LGTM

@rimolive
Copy link
Member

@chensun @zijianjoy Bumping this membership request. Anything missing or something we should review?

@zijianjoy
Copy link
Contributor

/approve

Welcome to the community ! @HumairAK

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit edc9c9c into kubeflow:master Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HumairAK as member to kubeflow org.
5 participants