Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 lynx sim #414

Merged
merged 19 commits into from
Sep 20, 2024
Merged

Ros2 lynx sim #414

merged 19 commits into from
Sep 20, 2024

Conversation

rafal-gorecki
Copy link
Contributor

@rafal-gorecki rafal-gorecki commented Sep 17, 2024

Description

  • working lynx simulation
  • yaml argument parser
  • create function, which validat robot configuration
  • add welcome_msg
  • delete multiple robot spawn difficult to create new one

Requirements

  • Code style guidelines followed
  • Documentation updated

Tests 🧪

  • Robot
  • Container
  • Simulation

Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)
  • ros2-devel

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rafal-gorecki rafal-gorecki requested a review from KmakD September 17, 2024 16:39
panther_bringup/launch/bringup.launch.py Outdated Show resolved Hide resolved
panther_bringup/launch/bringup.launch.py Outdated Show resolved Hide resolved
panther_gazebo/launch/simulate_robot.launch.py Outdated Show resolved Hide resolved
panther_gazebo/launch/simulate_robot.launch.py Outdated Show resolved Hide resolved
panther_utils/panther_utils/arguments.py Outdated Show resolved Hide resolved
panther_utils/panther_utils/arguments.py Outdated Show resolved Hide resolved
panther_utils/panther_utils/arguments.py Outdated Show resolved Hide resolved
panther_gazebo/launch/simulation.launch.py Outdated Show resolved Hide resolved
panther_gazebo/config/configuration.yaml Outdated Show resolved Hide resolved
@rafal-gorecki
Copy link
Contributor Author

Revert YAML configuration file

Explanation: I was wondering how to protect myself against possible wrong configurations. However, this brings a number of complications and all the arguments for admission to YAML would be necessary to make it consistent, but this is an approach that is unfamiliar to the team and I prefer to leave it as it is for now.

@rafal-gorecki rafal-gorecki requested a review from KmakD September 18, 2024 13:38
panther_gazebo/launch/simulate_robot.launch.py Outdated Show resolved Hide resolved
panther_gazebo/launch/spawn_robot.launch.py Outdated Show resolved Hide resolved
@rafal-gorecki rafal-gorecki requested a review from KmakD September 19, 2024 09:27
@KmakD KmakD merged commit 2430738 into ros2-lynx-devel Sep 20, 2024
1 check passed
@KmakD KmakD deleted the ros2-lynx-sim branch September 20, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants