Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eve cluster part2: Add EveWeather attributes #855

Merged
merged 12 commits into from
Aug 16, 2024

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Aug 12, 2024

Add Class attribute for Eve Cluster (EveWeather device):

  • Altitude
  • Pressure

HA core PR: Add EveWeatherPressure attribute #123565

@lboue lboue changed the title Eve cluster part2 Eve cluster part2: Add EveWeather attributes Aug 12, 2024
@lboue lboue marked this pull request as ready for review August 12, 2024 15:43
@agners agners added the new-feature New feature or request label Aug 12, 2024
altitude attribute doesn't change so no need to be polled
Fix attribute type
Altitude attribute
matter_server/common/custom_clusters.py Outdated Show resolved Hide resolved
matter_server/common/custom_clusters.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And finally, you also need to adjust it here:

Label="altitude", Tag=0x130A0013, Type=int

matter_server/common/custom_clusters.py Outdated Show resolved Hide resolved
matter_server/common/custom_clusters.py Outdated Show resolved Hide resolved
matter_server/common/custom_clusters.py Outdated Show resolved Hide resolved
@lboue
Copy link
Contributor Author

lboue commented Aug 16, 2024

And finally, you also need to adjust it here:

Label="altitude", Tag=0x130A0013, Type=int

Fixed.

@lboue lboue requested a review from agners August 16, 2024 13:34
Copy link
Collaborator

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, LGTM! Thanks!

matter_server/common/custom_clusters.py Outdated Show resolved Hide resolved
@agners agners merged commit 4734970 into home-assistant-libs:main Aug 16, 2024
4 checks passed
@lboue lboue deleted the EveCluster-part2 branch August 16, 2024 14:03
@lboue
Copy link
Contributor Author

lboue commented Sep 3, 2024

Working fine with 6.5.0 BETA 1 version:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants