Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EveWeather Pressure and Altitude attributes #123565

Closed
wants to merge 24 commits into from
Closed

Add EveWeather Pressure and Altitude attributes #123565

wants to merge 24 commits into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Aug 11, 2024 •
edited
Loading

Breaking change

Proposed change

  • Add Pressure and Altitude attributes for EveWeather device
  • Bump python-matter-server dependency to version 6.5.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

image

@lboue
Update sensor.py
3a198f6 
Add EveWeatherPressure attribute
@home-assistant home-assistant bot added cla-signed integration: matter small-pr PRs with less than 30 lines. labels Aug 11, 2024
@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@lboue lboue mentioned this pull request Aug 16, 2024
Merged
@lboue lboue changed the title Add EveWeatherPressure attribute Add EveWeather Pressure and Altitute attributes Aug 16, 2024
@lboue lboue marked this pull request as ready for review August 16, 2024 19:57
@lboue lboue requested a review from a team as a code owner August 16, 2024 19:57
@lboue lboue changed the title Add EveWeather Pressure and Altitute attributes Add EveWeather Pressure and Altitude attributes Aug 16, 2024
@lboue
Copy link
Contributor Author

lboue commented Aug 16, 2024 •
edited
Loading

It looks ready for the code review.

agners
agners approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

homeassistant/components/matter/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/matter/strings.json Outdated Show resolved Hide resolved
@marcelveldt

This comment was marked as outdated.

Sign in to view
@marcelveldt
Copy link
Member

Sorry, I missed the discovery that Eve fixed this already. Nice !

@lboue
Copy link
Contributor Author

lboue commented Aug 20, 2024

Is it OK to validate?

MartinHjelmare
MartinHjelmare requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests.

@home-assistant
Copy link

home-assistant bot commented Sep 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 9, 2024 20:32
@lboue lboue closed this Sep 10, 2024
@agners
Copy link
Member

agners commented Sep 11, 2024 •
edited
Loading

Superseeded by #125690.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcelveldt marcelveldt marcelveldt left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare requested changes

@agners agners agners approved these changes

Assignees
No one assigned
Labels
cla-signed integration: matter Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lboue @marcelveldt @agners @MartinHjelmare