Add Pressure and Altitude discovery schemas for Matter Eve Weather device #125690

lboue · 2024-09-10T18:15:24Z

Breaking change

Proposed change

Add Pressure and Altitude attributes for EveWeather device

Altitude
"1/319486977/319422483": 40.0,

Pressure
"1/319486977/319422484": 1008.5,

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue:
This PR is related to issue:
This PR is related to PR: Add Eve Weather custom attributes #842 and #855.
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

Local testing:

home-assistant · 2024-09-10T18:15:30Z

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

lboue · 2024-09-10T19:23:59Z

I don't understand why testing can't find the Pressure attribute.

Python 3.12.6
Error: homeassistant/components/matter/sensor.py:249: error: "type[Attributes]" has no attribute "Pressure"  [attr-defined]
Error: homeassistant/components/matter/number.py:154: error: "type[Attributes]" has no attribute "Altitude"  [attr-defined]
Found 2 errors in 2 files (checked 24 source files)
Error: Process completed with exit code 1.

It is defined here:

https://github.com/lboue/python-matter-server/blob/main/matter_server/common/custom_clusters.py#L269-L288

TheJulianJES · 2024-09-10T20:26:05Z

It's likely not included in the library version that HA uses at the moment: https://github.com/home-assistant/core/blob/dev/homeassistant/components/matter/manifest.json
It should probably be bumped to 6.5.0.

lboue · 2024-09-11T05:36:53Z

It's likely not included in the library version that HA uses at the moment: https://github.com/home-assistant/core/blob/dev/homeassistant/components/matter/manifest.json It should probably be bumped to 6.5.0.

Thanks. I changed it in the manifest.json file but it still fails.

core/homeassistant/components/matter/manifest.json

Line 9 in 15787b9

"requirements": ["python-matter-server==6.5.0"],

marcelveldt · 2024-09-11T10:50:30Z

Thanks. I changed it in the manifest.json file but it still fails.

Did you run HA once so it installed the version you specified in the manifest ?

lboue · 2024-09-11T12:16:23Z

Now I only have 1 failing checks

=========================== short test summary info ============================
ERROR tests/components/matter/test_sensor.py::test_eve_weather_sensor_custom_cluster[True] - AttributeError: 'NoneType' object has no attribute 'items'
Error: Process completed with exit code 1.

lboue · 2024-09-11T12:16:32Z

Thanks. I changed it in the manifest.json file but it still fails.

Did you run HA once so it installed the version you specified in the manifest ?

Fixed by 0d55f5d

lboue · 2024-09-12T08:47:52Z

Someone could help me to fix this error?

ERROR tests/components/matter/test_sensor.py::test_eve_weather_sensor_custom_cluster[True] - AttributeError: 'NoneType' object has no attribute 'items'

lboue · 2024-09-12T20:17:05Z

Local testing:

homeassistant/components/matter/manifest.json

marcelveldt · 2024-09-24T14:38:24Z

Someone could help me to fix this error?

ERROR tests/components/matter/test_sensor.py::test_eve_weather_sensor_custom_cluster[True] - AttributeError: 'NoneType' object has no attribute 'items'

For next time, you need to look carefully at the format of the node fixtures. Its not exactly the same as the diagnostics dump. Basically its only the "node" section of the diagnostics dump.

Pressure AttributeId: 319422484 (0x00130a0014) - Value type: float32

Bump to python-matter-server==6.5.0

Bump requirements to python-matter-server 6.5.0

lboue · 2024-09-24T14:47:06Z

For next time, you need to look carefully at the format of the node fixtures. Its not exactly the same as the diagnostics dump. Basically its only the "node" section of the diagnostics dump.

Is there a script to extract it or do you have to do it by hand?

…ue/ha_core into pr/125690

marcelveldt · 2024-09-24T15:13:00Z

Is there a script to extract it or do you have to do it by hand?

Just do it by hand. You simply move the "node" section one level up and remove the rest.

I have now adjusted this PR for you so for this PR its not needed

marcelveldt

Approved from my PoV but can use an extra pair of eyes as I finished this PR's tests

joostlek · 2024-09-24T15:16:35Z

homeassistant/components/matter/number.py

+        entity_description=MatterNumberEntityDescription(
+            key="EveWeatherAltitude",
+            entity_category=EntityCategory.CONFIG,
+            translation_key="altitude",
+            native_max_value=9000,
+            native_min_value=0,
+            native_unit_of_measurement=UnitOfLength.METERS,
+            native_step=1,
+            mode=NumberMode.BOX,
+        ),


no device class?

MartinHjelmare · 2024-09-25T07:49:53Z

tests/components/matter/test_sensor.py

@@ -92,6 +92,16 @@ async def eve_energy_plug_patched_node_fixture(
    )


+@pytest.fixture(name="eve_weather_sensor_node")
+async def eve_weather_sensor_node_fixture(


Please don't duplicate the same fixture in different modules. Put it in the conftest.py module instead. Those fixtures can be accessed by the whole test package.

home-assistant bot added cla-signed integration: matter new-feature labels Sep 10, 2024

home-assistant bot added the Quality Scale: No score label Sep 10, 2024

agners mentioned this pull request Sep 11, 2024

Add EveWeather Pressure and Altitude attributes #123565

Closed

19 tasks

marcelveldt reviewed Sep 24, 2024

View reviewed changes

homeassistant/components/matter/manifest.json Outdated Show resolved Hide resolved

lboue added 14 commits September 24, 2024 16:40

Update number.py to add EveWeatherAltitude attribute

7a839df

Update sensor.py to add EveCluster Pressure Attribute

3cd506b

Update strings.json

013b064

Create eve-weather-sensor.json

92baf3f

Update test_sensor.py

271ad79

Update eve-weather-sensor.json

b2d3979

Update test_sensor.py

fe967a3

Pressure AttributeId: 319422484 (0x00130a0014) - Value type: float32

Update test_sensor.py

6f4b38d

Update test_sensor.py

ad18a17

Update test_sensor.py

47b7110

Update manifest.json

7115725

Bump to python-matter-server==6.5.0

Update requirements_all.txt

5e47ee4

Bump requirements to python-matter-server 6.5.0

Update requirements_test_all.txt

1c48820

Bump requirements to python-matter-server 6.5.0

Update test_sensor.py

084b5a8

lboue and others added 7 commits September 24, 2024 16:41

Update sensor.py

7f55114

Update test_sensor.py

210140c

Update sensor.py

76d2ba9

Update test_sensor.py

57f2d0a

Update test_sensor.py

b83ee7e

Update test_sensor.py

9a424a9

fix test fixture

bfe6d30

marcelveldt force-pushed the EveWeather_custom_attributes branch from 7bbb614 to bfe6d30 Compare September 24, 2024 14:41

marcelveldt added 3 commits September 24, 2024 16:41

Update requirements_all.txt

36fc7a5

Update requirements_test_all.txt

17f86f1

Update manifest.json

08b7ac5

lboue and others added 3 commits September 24, 2024 16:47

Merge branch 'dev' into EveWeather_custom_attributes

1245aa6

fix tests

cf8ab3e

Merge branch 'EveWeather_custom_attributes' of https://github.com/lbo…

1b46f2d

…ue/ha_core into pr/125690

Update test_sensor.py

1f02c22

marcelveldt marked this pull request as ready for review September 24, 2024 15:15

marcelveldt requested a review from a team as a code owner September 24, 2024 15:15

marcelveldt approved these changes Sep 24, 2024

View reviewed changes

joostlek reviewed Sep 24, 2024

View reviewed changes

marcelveldt added this to the 2024.10.0b0 milestone Sep 24, 2024

marcelveldt changed the title ~~Add EveWeather Pressure and Altitude attributes~~ Add Pressure and Altitude sensor discovery schemas for Matter Eve Weather device Sep 24, 2024

marcelveldt changed the title ~~Add Pressure and Altitude sensor discovery schemas for Matter Eve Weather device~~ Add Pressure and Altitude discovery schemas for Matter Eve Weather device Sep 24, 2024

add device class

5d4a720

joostlek approved these changes Sep 24, 2024

View reviewed changes

joostlek merged commit 31a1ad8 into home-assistant:dev Sep 24, 2024
30 checks passed

MartinHjelmare reviewed Sep 25, 2024

View reviewed changes

lboue deleted the EveWeather_custom_attributes branch September 25, 2024 11:21

github-actions bot locked and limited conversation to collaborators Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Pressure and Altitude discovery schemas for Matter Eve Weather device #125690

Add Pressure and Altitude discovery schemas for Matter Eve Weather device #125690

lboue commented Sep 10, 2024 •

edited by marcelveldt

Loading

home-assistant bot commented Sep 10, 2024

lboue commented Sep 10, 2024

TheJulianJES commented Sep 10, 2024

lboue commented Sep 11, 2024 •

edited

Loading

marcelveldt commented Sep 11, 2024

lboue commented Sep 11, 2024

lboue commented Sep 11, 2024 •

edited

Loading

lboue commented Sep 12, 2024

lboue commented Sep 12, 2024

marcelveldt commented Sep 24, 2024

lboue commented Sep 24, 2024

marcelveldt commented Sep 24, 2024

marcelveldt left a comment

joostlek Sep 24, 2024

marcelveldt Sep 24, 2024

MartinHjelmare Sep 25, 2024

Add Pressure and Altitude discovery schemas for Matter Eve Weather device #125690

Add Pressure and Altitude discovery schemas for Matter Eve Weather device #125690

Conversation

lboue commented Sep 10, 2024 • edited by marcelveldt Loading

Breaking change

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Sep 10, 2024

lboue commented Sep 10, 2024

TheJulianJES commented Sep 10, 2024

lboue commented Sep 11, 2024 • edited Loading

marcelveldt commented Sep 11, 2024

lboue commented Sep 11, 2024

lboue commented Sep 11, 2024 • edited Loading

lboue commented Sep 12, 2024

lboue commented Sep 12, 2024

marcelveldt commented Sep 24, 2024

lboue commented Sep 24, 2024

marcelveldt commented Sep 24, 2024

marcelveldt left a comment

Choose a reason for hiding this comment

joostlek Sep 24, 2024

Choose a reason for hiding this comment

marcelveldt Sep 24, 2024

Choose a reason for hiding this comment

MartinHjelmare Sep 25, 2024

Choose a reason for hiding this comment

lboue commented Sep 10, 2024 •

edited by marcelveldt

Loading

lboue commented Sep 11, 2024 •

edited

Loading

lboue commented Sep 11, 2024 •

edited

Loading