CAPA: use lower heartbeat timeout to allow spot instances to terminate more quickly #173
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gacko
approved these changes
Dec 10, 2024
fiunchinho
requested changes
Dec 11, 2024
AndiDog
changed the title
True, forgot that despite ticking the checkbox 😆. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to giantswarm/aws-nth-crossplane-resources#7, towards https://github.com/giantswarm/giantswarm/issues/31843 and https://github.com/giantswarm/giantswarm/issues/32232
Requires giantswarm/cluster-aws#960 ported to
cluster-aws@main.What does this PR do?
See comment in code. Tests would time out if we don't specify this together with EC2 Spot instance usage.
Checklist