Bump cluster-standup-teardown to v1.27.4 to use lower lifecycle hooks heartbeat timeout to allow spot instances to terminate more quickly (CAPA)
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks heartbeat timeout to allow spot instances to terminate more quickly (CAPA)
fiunchinho
approved these changes
Dec 11, 2024
AndiDog
added
the
skip/ci
paurosello
approved these changes
Dec 11, 2024
Gacko
approved these changes
Dec 11, 2024
|
This worked for me in a locally-run test and used the correct, reduced lifecycle hook heart beat timeout. Therefore I'm merging this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Use giantswarm/cluster-standup-teardown#173 to prevent test from timing out because EC2 spot instances can't terminate quickly.
Towards https://github.com/giantswarm/giantswarm/issues/31843 and https://github.com/giantswarm/giantswarm/issues/32232.
Checklist
Trigger e2e tests
Chicken-egg problem, so I'll run these on the cluster-aws PR instead.