Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPA: use lower heartbeat timeout to allow spot instances to terminate more quickly #173

Merged
merged 1 commit into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- CAPA: use lower heartbeat timeout to allow spot instances to terminate more quickly

## [1.27.3] - 2024-11-13

### Changed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ global:
maxSize: 5
minSize: 2
rootVolumeSizeGB: 25

# With spot instances, aws-node-termination-handler may not receive any ASG lifecycle hook events
# and we don't want to wait for the default 30 minutes of heartbeat timeout before instances
# terminate. That would fail the tests. This can be fixed once heartbeats are implemented
# (https://github.com/aws/aws-node-termination-handler/issues/493), since then we would reduce
# cluster-aws's defaults to a low value, let's say `heartbeatTimeout: 5m` and `globalTimeout: 30m`.
awsNodeTerminationHandler:
heartbeatTimeoutSeconds: 100

spotInstances:
enabled: true
maxPrice: 0.2960
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ global:
maxSize: 5
minSize: 2
rootVolumeSizeGB: 25

# With spot instances, aws-node-termination-handler may not receive any ASG lifecycle hook events
# and we don't want to wait for the default 30 minutes of heartbeat timeout before instances
# terminate. That would fail the tests. This can be fixed once heartbeats are implemented
# (https://github.com/aws/aws-node-termination-handler/issues/493), since then we would reduce
# cluster-aws's defaults to a low value, let's say `heartbeatTimeout: 5m` and `globalTimeout: 30m`.
awsNodeTerminationHandler:
heartbeatTimeoutSeconds: 100

spotInstances:
enabled: true
maxPrice: 0.2960
Expand Down
Loading