Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Warehouse): add buttons only if the user can use them #42232

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(Warehouse): add buttons only if the user can use them #42232

merged 1 commit into from
Jul 10, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Jul 8, 2024 •
edited
Loading

Avoid adding buttons that will throw a permission error when the user clicks on them.

Before

frm.add_custom_button()

After

if (has_required_perm()) {
    frm.add_custom_button()
}

@barredterra barredterra merged commit 2254918 into frappe:develop Jul 10, 2024
18 checks passed
@barredterra barredterra deleted the warehouse-buttons branch July 10, 2024 11:14
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
barredterra added a commit that referenced this pull request Jul 10, 2024
@barredterra
Merge pull request #42273 from frappe/mergify/bp/version-15-hotfix/pr…
2751a9a 
…-42232

fix(Warehouse): add buttons only if the user can use them (backport #42232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vorasmit vorasmit vorasmit approved these changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barredterra @vorasmit