Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Warehouse): add buttons only if the user can use them #42232

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(Warehouse): add buttons only if the user can use them #42232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 28 additions & 20 deletions erpnext/stock/doctype/warehouse/warehouse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,32 +40,40 @@ frappe.ui.form.on("Warehouse", {
if (!frm.is_new()) {
frappe.contacts.render_address_and_contact(frm);

let enable_toggle = frm.doc.disabled ? "Enable" : "Disable";
frm.add_custom_button(__(enable_toggle), () => {
frm.set_value("disabled", 1 - frm.doc.disabled);
frm.save();
});

frm.add_custom_button(__("Stock Balance"), function () {
frappe.set_route("query-report", "Stock Balance", {
warehouse: frm.doc.name,
company: frm.doc.company,
if (frm.has_perm("write")) {
let enable_toggle = frm.doc.disabled ? "Enable" : "Disable";
frm.add_custom_button(__(enable_toggle), () => {
frm.set_value("disabled", 1 - frm.doc.disabled);
frm.save();
});
});

frm.add_custom_button(
frm.doc.is_group
? __("Convert to Ledger", null, "Warehouse")
: __("Convert to Group", null, "Warehouse"),
function () {
convert_to_group_or_ledger(frm);
}
);
frm.add_custom_button(
frm.doc.is_group
? __("Convert to Ledger", null, "Warehouse")
: __("Convert to Group", null, "Warehouse"),
function () {
convert_to_group_or_ledger(frm);
}
);
}

if ("Stock Balance" in frappe.boot.user.all_reports) {
frm.add_custom_button(__("Stock Balance"), function () {
frappe.set_route("query-report", "Stock Balance", {
warehouse: frm.doc.name,
company: frm.doc.company,
});
});
}
} else {
frappe.contacts.clear_address_and_contact(frm);
}

if (!frm.doc.is_group && frm.doc.__onload && frm.doc.__onload.account) {
if (
!frm.doc.is_group &&
frm.doc.__onload?.account &&
"General Ledger" in frappe.boot.user.all_reports
) {
frm.add_custom_button(__("General Ledger", null, "Warehouse"), function () {
frappe.route_options = {
account: frm.doc.__onload.account,
Expand Down
Loading