Skip to content

Commit

Permalink
Merge pull request #42273 from frappe/mergify/bp/version-15-hotfix/pr…
Browse files Browse the repository at this point in the history
…-42232

fix(Warehouse): add buttons only if the user can use them (backport #42232)
  • Loading branch information
barredterra committed Jul 10, 2024
2 parents 92bc227 + a2b21c7 commit 2751a9a
Showing 1 changed file with 28 additions and 20 deletions.
48 changes: 28 additions & 20 deletions erpnext/stock/doctype/warehouse/warehouse.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,32 +40,40 @@ frappe.ui.form.on("Warehouse", {
if (!frm.is_new()) {
frappe.contacts.render_address_and_contact(frm);

let enable_toggle = frm.doc.disabled ? "Enable" : "Disable";
frm.add_custom_button(__(enable_toggle), () => {
frm.set_value("disabled", 1 - frm.doc.disabled);
frm.save();
});

frm.add_custom_button(__("Stock Balance"), function () {
frappe.set_route("query-report", "Stock Balance", {
warehouse: frm.doc.name,
company: frm.doc.company,
if (frm.has_perm("write")) {
let enable_toggle = frm.doc.disabled ? "Enable" : "Disable";
frm.add_custom_button(__(enable_toggle), () => {
frm.set_value("disabled", 1 - frm.doc.disabled);
frm.save();
});
});

frm.add_custom_button(
frm.doc.is_group
? __("Convert to Ledger", null, "Warehouse")
: __("Convert to Group", null, "Warehouse"),
function () {
convert_to_group_or_ledger(frm);
}
);
frm.add_custom_button(
frm.doc.is_group
? __("Convert to Ledger", null, "Warehouse")
: __("Convert to Group", null, "Warehouse"),
function () {
convert_to_group_or_ledger(frm);
}
);
}

if ("Stock Balance" in frappe.boot.user.all_reports) {
frm.add_custom_button(__("Stock Balance"), function () {
frappe.set_route("query-report", "Stock Balance", {
warehouse: frm.doc.name,
company: frm.doc.company,
});
});
}
} else {
frappe.contacts.clear_address_and_contact(frm);
}

if (!frm.doc.is_group && frm.doc.__onload && frm.doc.__onload.account) {
if (
!frm.doc.is_group &&
frm.doc.__onload?.account &&
"General Ledger" in frappe.boot.user.all_reports
) {
frm.add_custom_button(__("General Ledger", null, "Warehouse"), function () {
frappe.route_options = {
account: frm.doc.__onload.account,
Expand Down

0 comments on commit 2751a9a

Please sign in to comment.