You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We locked the ubuntu image for Firefox tests 2 years ago: #6833 because the new image was having issues. Hopefully that's been fixed by now, trying ubuntu-latest.
Conclusion: Firefox installed with apt-get seems to cause issues on Ubuntu 22.04, perhaps because of some conflict with Ubuntu 22.04's own pre-installed Snap version of Firefox. This can be solved either by removing the Firefox install altogether or by installing with puppeteer instead, which seems to not cause a conflict. Although removing the install and relying on the image's pre-installed Firefox works fine, and Github seems to update their Ubuntu regularly so it always has the latest version of Firefox, I prefer to use puppeteer for explicit control over the version. Maybe we want to lock it to some specific version or test with a specific version in the future, and this sets us up to easily do that.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Locking it to ubuntu-20.04 until we can figure out why (hopefully it isn't that current and future versions of Firefox don't work with karma-firefox-launcher).
Ubuntu 22.04 has a "snap" version of Firefox built in, which doesn't seem to work well. As part of the workflow, we install Firefox fresh with apt-get but I think the command "firefox" still is pointing at the snap version and not at the one we just installed, maybe? That seems to be the command karma-firefox-launcher uses ("firefox").
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We locked the ubuntu image for Firefox tests 2 years ago: #6833 because the new image was having issues. Hopefully that's been fixed by now, trying ubuntu-latest.
Conclusion: Firefox installed with apt-get seems to cause issues on Ubuntu 22.04, perhaps because of some conflict with Ubuntu 22.04's own pre-installed Snap version of Firefox. This can be solved either by removing the Firefox install altogether or by installing with puppeteer instead, which seems to not cause a conflict. Although removing the install and relying on the image's pre-installed Firefox works fine, and Github seems to update their Ubuntu regularly so it always has the latest version of Firefox, I prefer to use puppeteer for explicit control over the version. Maybe we want to lock it to some specific version or test with a specific version in the future, and this sets us up to easily do that.