Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-latest for Firefox CI tests #8671

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Use ubuntu-latest for Firefox CI tests #8671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2312d47
Run firefox tests on ubuntu-latest to see if they work
hsubox76 Dec 9, 2024
766ef28
add comment to trigger CI
hsubox76 Dec 9, 2024
6bfe323
Try unsetting snap env vars
hsubox76 Dec 10, 2024
896c8ad
Try some options
hsubox76 Dec 11, 2024
f42477a
A/B test, no firefox install vs puppeteer
hsubox76 Dec 11, 2024
ec08146
Use puppeteer for all Firefox installs
hsubox76 Dec 11, 2024
4115828
remove FIXME
hsubox76 Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/test-changed-auth.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,19 +70,12 @@ jobs:
run: xvfb-run yarn test:changed auth
test-firefox:
name: Test Auth on Firefox If Changed
# Whatever version of Firefox comes with 22.04 is causing Firefox
# startup to hang when launched by karma. Need to look further into
# why.

runs-on: ubuntu-20.04
runs-on: ubuntu-latest

steps:
- name: install Firefox stable
run: |
sudo apt-get update
sudo apt-get install firefox
sudo apt-get install wget

run: npx @puppeteer/browsers install firefox@stable
- name: Checkout Repo
uses: actions/checkout@v4
with:
Expand Down
18 changes: 4 additions & 14 deletions .github/workflows/test-changed-firestore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,17 +169,12 @@ jobs:

compat-test-firefox:
name: Test Firestore Compatible on Firefox
# Whatever version of Firefox comes with 22.04 is causing Firefox
# startup to hang when launched by karma. Need to look further into
# why.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: build
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: install Firefox stable
run: |
sudo apt-get update
sudo apt-get install firefox
run: npx @puppeteer/browsers install firefox@stable
- name: Set up Node (20)
uses: actions/setup-node@v3
with:
Expand All @@ -202,17 +197,12 @@ jobs:
strategy:
matrix:
test-name: ["test:browser", "test:travis", "test:lite:browser", "test:browser:prod:nameddb", "test:lite:browser:nameddb"]
# Whatever version of Firefox comes with 22.04 is causing Firefox
# startup to hang when launched by karma. Need to look further into
# why.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
needs: build
if: ${{ needs.build.outputs.changed == 'true'}}
steps:
- name: install Firefox stable
run: |
sudo apt-get update
sudo apt-get install firefox
run: npx @puppeteer/browsers install firefox@stable
- name: Download build archive
uses: actions/download-artifact@v3
with:
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/test-changed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,7 @@ jobs:

test-firefox:
name: Test Packages With Changed Files in Firefox
# Whatever version of Firefox comes with 22.04 is causing Firefox
# startup to hang when launched by karma. Need to look further into
# why.
runs-on: ubuntu-20.04
runs-on: ubuntu-latest

steps:
- name: Checkout Repo
Expand All @@ -65,9 +62,7 @@ jobs:
with:
node-version: 22.10.0
- name: install Firefox stable
run: |
sudo apt-get update
sudo apt-get install firefox
run: npx @puppeteer/browsers install firefox@stable
- name: Test setup and yarn install
run: |
cp config/ci.config.json config/project.json
Expand Down
Loading