Use ubuntu-latest for Firefox CI tests (#8671)

firebase · Dec 11, 2024 · 76c3641 · 76c3641
1 parent cbec4b9
commit 76c3641
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 30 deletions.
diff --git a/.github/workflows/test-changed-auth.yml b/.github/workflows/test-changed-auth.yml
@@ -70,19 +70,12 @@ jobs:
         run: xvfb-run yarn test:changed auth
   test-firefox:
     name: Test Auth on Firefox If Changed
-    # Whatever version of Firefox comes with 22.04 is causing Firefox
-    # startup to hang when launched by karma. Need to look further into
-    # why.
 
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: install Firefox stable
-        run: |
-          sudo apt-get update
-          sudo apt-get install firefox
-          sudo apt-get install wget
-
+        run: npx @puppeteer/browsers install firefox@stable
       - name: Checkout Repo
         uses: actions/checkout@v4
         with:

diff --git a/.github/workflows/test-changed-firestore.yml b/.github/workflows/test-changed-firestore.yml
@@ -169,17 +169,12 @@ jobs:
 
   compat-test-firefox:
     name: Test Firestore Compatible on Firefox
-    # Whatever version of Firefox comes with 22.04 is causing Firefox
-    # startup to hang when launched by karma. Need to look further into
-    # why.
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     needs: build
     if: ${{ needs.build.outputs.changed == 'true'}}
     steps:
       - name: install Firefox stable
-        run: |
-          sudo apt-get update
-          sudo apt-get install firefox
+        run: npx @puppeteer/browsers install firefox@stable
       - name: Set up Node (20)
         uses: actions/setup-node@v3
         with:
@@ -202,17 +197,12 @@ jobs:
     strategy:
       matrix:
         test-name: ["test:browser", "test:travis", "test:lite:browser", "test:browser:prod:nameddb", "test:lite:browser:nameddb"]
-    # Whatever version of Firefox comes with 22.04 is causing Firefox
-    # startup to hang when launched by karma. Need to look further into
-    # why.
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
     needs: build
     if: ${{ needs.build.outputs.changed == 'true'}}
     steps:
       - name: install Firefox stable
-        run: |
-          sudo apt-get update
-          sudo apt-get install firefox
+        run: npx @puppeteer/browsers install firefox@stable
       - name: Download build archive
         uses: actions/download-artifact@v3
         with:

diff --git a/.github/workflows/test-changed.yml b/.github/workflows/test-changed.yml
@@ -50,10 +50,7 @@ jobs:
 
   test-firefox:
     name: Test Packages With Changed Files in Firefox
-    # Whatever version of Firefox comes with 22.04 is causing Firefox
-    # startup to hang when launched by karma. Need to look further into
-    # why.
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: Checkout Repo
@@ -65,9 +62,7 @@ jobs:
         with:
           node-version: 22.10.0
       - name: install Firefox stable
-        run: |
-          sudo apt-get update
-          sudo apt-get install firefox
+        run: npx @puppeteer/browsers install firefox@stable
       - name: Test setup and yarn install
         run: |
           cp config/ci.config.json config/project.json