Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Transaction order conformance test for state stores #1496

Closed
wants to merge 4 commits into from
Closed

[WIP] Transaction order conformance test for state stores #1496

wants to merge 4 commits into from

Conversation

shubham1172
Copy link
Member

Description

Introduces a new test that checks the order of transactions. Say a transaction that contains the following:

upsert k1 v1
delete k1
upsert k2 v2

The order of operations must be respected, and k1 should be deleted, whilst k2 should have a value of v2.

Note, an anomaly was found in Cosmos DB state store in #1209, and it was also found that the transaction run fails to maintain the order in alternate runs.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1210

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number] (NA)

Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
@shubham1172 shubham1172 requested review from a team as code owners February 11, 2022 11:57
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1496 (96e4b26) into master (625f955) will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1496   +/-   ##
=======================================
  Coverage   35.29%   35.29%           
=======================================
  Files         157      157           
  Lines       14241    14242    +1     
=======================================
+ Hits         5026     5027    +1     
  Misses       8692     8692           
  Partials      523      523           
Impacted Files Coverage Δ
bindings/mysql/mysql.go 46.89% <0.00%> (ø)
state/azure/cosmosdb/cosmosdb_query.go 55.05% <100.00%> (ø)
state/mongodb/mongodb_query.go 40.00% <100.00%> (ø)
state/postgresql/postgresql_query.go 59.18% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdebda...96e4b26. Read the comment docs.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New conf test scenario for state stores: transaction order
2 participants