-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transaction API for Azure SQL server #1516
Merged
daixiang0
merged 5 commits into
dapr:master
from
shubham1172:shubham1172/fix-sql-server-transaction-api
Feb 22, 2022
Merged
Fix transaction API for Azure SQL server #1516
daixiang0
merged 5 commits into
dapr:master
from
shubham1172:shubham1172/fix-sql-server-transaction-api
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Sharma <[email protected]>
shubham1172
changed the title
[WIP] Fix transaction ordering for Azure SQL server
[WIP] Fix transaction API for Azure SQL server
Feb 21, 2022
Test from #1496 |
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
shubham1172
changed the title
[WIP] Fix transaction API for Azure SQL server
Fix transaction API for Azure SQL server
Feb 21, 2022
Signed-off-by: Shubham Sharma <[email protected]>
shubham1172
force-pushed
the
shubham1172/fix-sql-server-transaction-api
branch
from
February 21, 2022 10:50
1548d09
to
acde0fb
Compare
1 task
This is a needed fix, thanks for the PR. |
Codecov Report
@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
+ Coverage 35.29% 35.37% +0.07%
==========================================
Files 157 158 +1
Lines 14255 14336 +81
==========================================
+ Hits 5031 5071 +40
- Misses 8700 8730 +30
- Partials 524 535 +11
Continue to review full report at Codecov.
|
daixiang0
approved these changes
Feb 22, 2022
This was referenced Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Sharma [email protected]
Description
This PR introduces a logic for only keeping the latest operations per key in a transaction. This is similar to what was proposed in #1209 (comment). For example, say the original transaction is:
Since #1517 was a prerequisite, I have merged the changes with this one. It ignores row mismatch error while using bulk delete in transactions.
Issue reference
Please reference the issue this PR will close: #1505, #1517
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: