-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transaction API for Azure Cosmos DB #1518
Merged
artursouza
merged 19 commits into
dapr:master
from
shubham1172:shubham1172/fix-cosmos-db-transaction-api
Mar 9, 2022
Merged
Fix transaction API for Azure Cosmos DB #1518
artursouza
merged 19 commits into
dapr:master
from
shubham1172:shubham1172/fix-cosmos-db-transaction-api
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Sharma <[email protected]>
Test from #1496 |
Signed-off-by: Shubham Sharma <[email protected]>
…ithub.com/shubham1172/components-contrib into shubham1172/fix-cosmos-db-transaction-api
artursouza
requested changes
Feb 23, 2022
2 tasks
shubham1172
changed the title
Fix transaction API for Azure Cosmos DB
[WIP] Fix transaction API for Azure Cosmos DB
Feb 24, 2022
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
Signed-off-by: Shubham Sharma <[email protected]>
…ithub.com/shubham1172/components-contrib into shubham1172/fix-cosmos-db-transaction-api
Signed-off-by: Shubham Sharma <[email protected]>
… document Signed-off-by: Shubham Sharma <[email protected]>
shubham1172
changed the title
[WIP] Fix transaction API for Azure Cosmos DB
Fix transaction API for Azure Cosmos DB
Mar 3, 2022
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #1518 +/- ##
==========================================
- Coverage 35.40% 35.40% -0.01%
==========================================
Files 160 160
Lines 14616 14618 +2
==========================================
Hits 5175 5175
- Misses 8888 8890 +2
Partials 553 553
Continue to review full report at Codecov.
|
artursouza
approved these changes
Mar 9, 2022
berndverst
pushed a commit
to shivamkm07/components-contrib
that referenced
this pull request
Mar 11, 2022
* Fix cosmos transaction API to respect ordering Signed-off-by: Shubham Sharma <[email protected]> * refactor to an idiomatic way Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc caller to pass list of operations Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc to operate sequentially Signed-off-by: Shubham Sharma <[email protected]> * Add doc Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc to not throw error on delete failure due to missing document Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: Looong Dai <[email protected]> Signed-off-by: Bernd Verst <[email protected]>
berndverst
pushed a commit
to shivamkm07/components-contrib
that referenced
this pull request
Mar 11, 2022
* Fix cosmos transaction API to respect ordering Signed-off-by: Shubham Sharma <[email protected]> * refactor to an idiomatic way Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc caller to pass list of operations Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc to operate sequentially Signed-off-by: Shubham Sharma <[email protected]> * Add doc Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc Signed-off-by: Shubham Sharma <[email protected]> * Update storedproc to not throw error on delete failure due to missing document Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: Looong Dai <[email protected]> Signed-off-by: Bernd Verst <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Sharma [email protected]
Description
Similar to #1516, this introduces a logic to fix the ordering in a transaction. For a given key, only the latest operation is executed. The other operations are ignored. (From related PR: ) This is similar to what was proposed in #1209 (comment). For example, say the original transaction is:
Issue reference
Please reference the issue this PR will close: #1209
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: