Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ActualDirection calculation from SpecifiedDirection #4205

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix ActualDirection calculation from SpecifiedDirection #4205

wants to merge 1 commit into from

Commits on Jul 1, 2024

  1. Fix ActualDirection calculation from SpecifiedDirection 

    Unspecified direction maps to Output while Flip maps to Input.
Previously, ActualDirection.fromSpecified would return Unspecified for
either Unspecified or Flipped input. This in turn resulted in Bundles
mixing Unspecified and Outputs as being "bidirectional" despite the fact
that they are actually unidirectional (or passive).

This change makes the direction calculation more consistent albeit at
the cost of marking the directions of unspecified Data as Output.
    @jackkoenig @sequencer
    jackkoenig authored and sequencer committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    352043f View commit details
    Browse the repository at this point in the history