Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1.0 RTL with Lint Fixes #518

Open
wants to merge 30 commits into
base: patch_v1.0
Choose a base branch
from

Commits on Mar 13, 2024

  1. Issue 445 LINT fixes

    Matthew Border authored and calebofearth committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4c9e86c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Squashed commit of the following:

    commit e08900f
    Author: Michael Norris <[email protected]>
    Date:   Thu Mar 28 11:00:58 2024 -0700
    
        rolling back packed struct removal
        enabling lint on integrated TRNG files
        fixes for integrated TRNG lint violations
    
    commit 75ecd6c
    Author: Michael Norris <[email protected]>
    Date:   Wed Mar 27 12:59:24 2024 -0700
    
        fixing lint errors from LMS changes
    
    commit 3049b98
    Author: Caleb Whitehead <[email protected]>
    Date:   Thu Mar 28 16:44:43 2024 -0700
    
        Squashed commit of the following:
    
        commit f03b9ba
        Merge: bc73a52 55f5f95
        Author: Michael Norris <[email protected]>
        Date:   Wed Mar 27 12:51:20 2024 -0700
    
            Merge remote-tracking branch 'chips/main' into user/dev/michnorris/lint_fix
    
        commit bc73a52
        Author: Michael Norris <[email protected]>
        Date:   Wed Mar 27 12:45:42 2024 -0700
    
            removing change from other lint pr branch, not sure where it came from.
    
        commit 697a740
        Author: Michael Norris <[email protected]>
        Date:   Wed Mar 27 12:20:42 2024 -0700
    
            removing lint blackboxes
            removed packed struct post processing from generated reg files.
            cast width of dynamic shifts to make lint happy
            casting some arithmetic widths, math parameter widths etc
    
    commit a16581d
    Author: Michael Norris <[email protected]>
    Date:   Tue Mar 26 15:00:06 2024 -0700
    
        initial round of lint fixes
    calebofearth committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    fae37d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Regenerate RDL using updated peakrdl version

    Same as commits:
    17c0ce9459583a2250c6f292e0e468fbbf7c34
    2c4b61f
    at user/dev/michnorris/lint_fix
    calebofearth committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    c9f70d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. scrubbing enums in generated reg pkg files

    Michael Norris authored and calebofearth committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bf9c45d View commit details
    Browse the repository at this point in the history
  2. NVDA Lint Fixes on top of main_lint_regress branch

    Avirup Mullick authored and calebofearth committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    cbd06f9 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. matching number of bits on RHS of AND mask equation

    Michael Norris authored and calebofearth committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f7d608a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7fdc94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    53808f1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    897ec57 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf4dde3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8f8db41 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    592ae23 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    fe4deaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4fc07b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48a829b View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    76c4def View commit details
    Browse the repository at this point in the history
  2. rolling back change to modport to adhere to SV spec

    Michael Norris authored and calebofearth committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    095f6b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. fix to dmi reg data width lint violation

    Michael Norris authored and calebofearth committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    35432e8 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. [entropy_src] Keep applying fw_ov_rd_fifo_overflow (#506)

    Keep applying fw_ov_rd_fifo_overflow instead of pulsing. This commit is
    a manual port of the following Opentitan commit:
    
    b454878f2528b49318ff2b604cb8d59a6e59b0ea
    
    Which is associated with
    lowRISC/opentitan#21640.
    
    Original commit description:
    
    This commit applies the fw_ov_rd_fifo_overflow signal in case of an
    overflow. It used to only send a pulse through the register but now
    the signal is applied until the FIFO has been emptied once and is
    receiving contiguous data again.
    This commit also aligns the documentation for the FW_OV_RD_FIFO_OVERFLOW
    register. The register is now not clearable by software. It instead
    is cleared by hardware.
    
    Signed-off-by: Miguel Osorio <[email protected]>
    moidx authored and calebofearth committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4df4223 View commit details
    Browse the repository at this point in the history
  2. [LINT] Resolving unnamed generate blocks Lint warnings (#510)

    * Resolving unnamed generate blocks Lint warnings
    
    * Running stamp_repo.sh
    
    ---------
    
    Co-authored-by: Avirup Mullick <[email protected]>
    2 people authored and calebofearth committed May 17, 2024
    Configuration menu
    Copy the full SHA
    cf3b02d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3e7375d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f3a3306 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Fix for truncated bits after casting logical shifts to the incorrect …

    …width for lint fixes (#524)
    
    * fixing bugs caused during lint fixes where shifts were cast as the wrong width and bits are truncated
    fixed by removing the shifts and explicitly taking the bits required
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/lint_bug_fix' with updated timestamp and hash after successful run
    
    * updating smoke test to sha the entire mailbox at the start
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/lint_bug_fix' with updated timestamp and hash after successful run
    
    ---------
    
    Co-authored-by: Michael Norris <[email protected]>
    calebofearth and Michael Norris committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b87af3b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. KeyVault fixes and JTAG fix (#528)

    * patch for kv exfiltration
    locking api registers from being modified by uc when data is loaded from the keyvault
    updating smoke tests to attempt to corrupt the kv data to test the lock
    
    * updating kv smoke test to use keyvault for block register
    
    * adding multi block hmac keyvault test content
    
    * updating keyvault section of the hardware spec to explicitly call out the key locking/clearing inside the crypto function
    Also detailing the requirement that each iteration of a multi block operation must program the keyvault read/write operation
    
    * corrected the expected tag to match the expected output of the hmac block
    
    * adding multiblock test to l0 and nightly directed regressions
    
    * preventing commands from being issued while key is being copied to the crypto engine
    
    * changing the masking to just cover the idle case, no need to check for data present
    
    * added busy signal to crypto engines with key access
    multiple busy signals trigger a fatal error
    zeroize keyvault reads when read has an error
    updated ras test to include testing crypto error case
    
    * adding new port for busy signals and crypto errors to all the unit level testbenches
    
    * fixing jtag aperture to allow access to veer jtag registers only when debug is unlocked
    jtag path to soc ifc registers is unchanged
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/kv_vuln_fix' with updated timestamp and hash after successful run
    
    * Fix for truncated bits after casting logical shifts to the incorrect width for lint fixes (#524)
    
    * fixing bugs caused during lint fixes where shifts were cast as the wrong width and bits are truncated
    fixed by removing the shifts and explicitly taking the bits required
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/lint_bug_fix' with updated timestamp and hash after successful run
    
    * updating smoke test to sha the entire mailbox at the start
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/lint_bug_fix' with updated timestamp and hash after successful run
    
    ---------
    
    Co-authored-by: Michael Norris <[email protected]>
    
    * [ENV] Disable wget HSTS in ROM test (#527)
    
    * Disable HSTS (https is hardcoded in makefile, no MIM attack here)
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'cwhitehead-msft-rom-wget-hsts-disable' with updated timestamp and hash after successful run
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/kv_vuln_fix' with updated timestamp and hash after successful run
    
    * updating hardware spec for crypto error fatal error
    fixing some typos and doc nits
    updating covergroups to include new crypto error fatal error bit
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/kv_vuln_fix' with updated timestamp and hash after successful run
    
    * Apply suggested feedback
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/kv_vuln_fix' with updated timestamp and hash after successful run
    
    * Removed multiple write scenarios in kv
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/kv_vuln_fix' with updated timestamp and hash after successful run
    
    * updating register description for internal fw update reset wait cycle count to indicate that 5 is the minimum value allowed
    updating kv definition description to clarify that SHA is no longer a valid destination
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/kv_vuln_fix' with updated timestamp and hash after successful run
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/kv_vuln_fix' with updated timestamp and hash after successful run
    
    ---------
    
    Co-authored-by: Michael Norris <[email protected]>
    Co-authored-by: Michael Norris <[email protected]>
    Co-authored-by: Michael Norris <[email protected]>
    Co-authored-by: Caleb <[email protected]>
    Co-authored-by: Caleb Whitehead <[email protected]>
    Co-authored-by: Kiran Upadhyayula <[email protected]>
    7 people committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5e4a354 View commit details
    Browse the repository at this point in the history
  2. Fix for issue #523 - JTAG under reset during breakpoint (#541)

    * fix to fw upd reset signal to enable jtag during breakpoint
    updated predictor for fw upd reset signal
    
    * Update impactless fw update section
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/rdc_jtag_fix' with updated timestamp and hash after successful run
    
    * MICROSOFT AUTOMATED PIPELINE: Stamp 'user/dev/michnorris/rdc_jtag_fix' with updated timestamp and hash after successful run
    
    ---------
    
    Co-authored-by: Michael Norris <[email protected]>
    Co-authored-by: Caleb Whitehead <[email protected]>
    3 people committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    dc4154e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f280b02 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    e8afaa8 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    9e7cef1 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    e2dc3e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    aa6025f View commit details
    Browse the repository at this point in the history