Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more predefined rules conformance tests around repeated fields #258

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jchadwick-buf
Copy link
Member

This uncovers a minor bug in predefined rules on repeated fields that will need to be fixed in protovalidate-go.

@jchadwick-buf jchadwick-buf requested a review from rodaine October 1, 2024 17:49
Copy link

github-actions bot commented Oct 1, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 1, 2024, 5:49 PM

@rodaine rodaine changed the title Add more conformance tests Add more predefined rules conformance tests around repeated fields Oct 2, 2024
@rodaine rodaine merged commit adbfb45 into main Oct 2, 2024
7 checks passed
@rodaine rodaine deleted the jchadwick/more-predefined-rule-tests branch October 2, 2024 19:25
jchadwick-buf added a commit to bufbuild/protovalidate-go that referenced this pull request Oct 4, 2024
- [x] Update protovalidate conformance version once
bufbuild/protovalidate#258 is merged+released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants