Fix repeated predefined rule on repeated field #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jchadwick-buf
commented
Oct 1, 2024
•
jchadwick-buf
commented
- Update protovalidate conformance version once Add more predefined rules conformance tests around repeated fields protovalidate#258 is merged+released
|
The latest Buf updates on your PR. Results from workflow Buf / validate-protos (pull_request).
|
jchadwick-buf
commented
Oct 2, 2024
| celext.ProtoFieldToCELType(desc, true, forItems), | ||
| celext.ProtoFieldToCELValue(desc, rule, forItems), | ||
| celext.ProtoFieldToCELType(desc, true, false), | ||
| celext.ProtoFieldToCELValue(desc, rule, false), |
There was a problem hiding this comment.
Explanation for this just to make it extra clear: We don't want to propagate the forItems value here because it reflects if we're operating on a repeated element of the this field, not of the rule field. Instead, the only time forItems should be true for these specific calls should be when they recurse to get the inner element type/value. Otherwise, a repeated field with a predefined constraint applied will attempt to get the element type of the rule field itself, which does not make any sense.
oliversun9
approved these changes
Oct 2, 2024
rodaine
approved these changes
Oct 2, 2024
jchadwick-buf
deleted the
jchadwick/fix-repeated-predefined-rule-on-repeated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.