Skip to content

Commit

Permalink
Fix repeated predefined rule on repeated field (#150)
Browse files Browse the repository at this point in the history
- [x] Update protovalidate conformance version once
bufbuild/protovalidate#258 is merged+released
  • Loading branch information
jchadwick-buf authored Oct 4, 2024
1 parent 88c8cca commit 0861600
Show file tree
Hide file tree
Showing 5 changed files with 4,800 additions and 1,093 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ GOLANGCI_LINT_VERSION ?= v1.60.1
# Set to use a different version of protovalidate-conformance.
# Should be kept in sync with the version referenced in proto/buf.lock and
# 'buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go' in go.mod.
CONFORMANCE_VERSION ?= v0.8.1
CONFORMANCE_VERSION ?= v0.8.2

.PHONY: help
help: ## Describe useful make targets
Expand Down
4 changes: 2 additions & 2 deletions internal/constraints/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ func (c *Cache) Build(
fieldEnv, compileErr := env.Extend(
cel.Constant(
"rule",
celext.ProtoFieldToCELType(desc, true, forItems),
celext.ProtoFieldToCELValue(desc, rule, forItems),
celext.ProtoFieldToCELType(desc, true, false),
celext.ProtoFieldToCELValue(desc, rule, false),
),
)
if compileErr != nil {
Expand Down
Loading

0 comments on commit 0861600

Please sign in to comment.