-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vcpkg ci #1413
base: develop
Are you sure you want to change the base?
Add vcpkg ci #1413
Conversation
Cool, thanks for contributing !!! Workflow is failing for another reason, most likely OOM. I'm a bit swamped with getting boost out of 4.3 to land something like this right now, and I'll also like to learn a bit about this rather substantial PR. Can we have a call about this over the weekend or early next week? |
Yes, we can do on the weekend. |
Will do! Send an email to [email protected] to set up a time :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking a merge for now until I understand completely, but this looks cool!
Just type your comments here when you have time. If we need more interactive, I will send you an email :) Thanks! |
The email path is also so I can set up an invite. |
ff8119f
to
ea63e1d
Compare
@dellaert Are you still interested in these changes? |
27f55a6
to
f8c0265
Compare
All the tests are passing: |
a361a1b
to
11d5363
Compare
New things I develop from last time:
Bugs:
|
@varunagrawal |
I also got this error. Not sure how to fix it. You can see the error above |
Yup it's the same issue. Once we debug and fix that, I'll immediately review your PR. Thank you again for the amazing contribution and your patience. |
796401c
to
7107cb3
Compare
41feb93
to
3ebae3f
Compare
2063d98
to
8eb1882
Compare
503224f
to
9b4a30c
Compare
39a5adb
to
5923332
Compare
@varunagrawal This PR is ready for review. |
5923332
to
dac8f6f
Compare
6a9a037
to
5ab6a63
Compare
@dellaert This PR is ready for review. |
5ab6a63
to
739d121
Compare
Add vcpkg ci. Fix #672
I try to minimize the changes as much as possible.
I delete the
FindTBB.cmake
. I think it old file, and the default of the cmake is working well also on your tests.I also add to your workflow, that it will do test only when doing PR to devel and push to devel, as it your most use cases.
Also I add concurrency section, that it cancel automatic other check when you push to your PR another commit before the other check is not finish. It not doing that when you merge or push to devel, because each change there is important.
It useful to save resource and time for check your PRs.
Also there some bugs that I encounter that I think needed to fix in other PRs.
This PR already have many things to discuss.
This is start of infrastructure how to use vcpkg and can also extended (in other PRs). For example to publish binaries in the PR itself, that it can downloaded and test them externally.
Maybe other use cases you want to test.
My moto is to compile as much as possible in one test (and hopefully to run the tests themself), to know much quicker to the problem when you doing a PR.
I am not sure why the 2 of your workflow is failing, If it from stuff I did, I will happy to know, and try to fix accordingly.
gtsam bugs:
1. windows gtsam_unstableSolve!2. Errors on tests:Solve!3. windows python