Add planar trifocal tensor #1094
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add trifocal tensor constructor from bearing measurements
dellaert
reviewed
Feb 9, 2022
| @@ -0,0 +1,128 @@ | |||
| #include <iostream> | |||
dellaert
reviewed
Feb 9, 2022
| Matrix2 mat1() const { return matrix1_; } | ||
| }; | ||
|
|
||
| } // namespace gtsam |
dellaert
requested changes
Feb 9, 2022
dellaert
reviewed
Feb 9, 2022
| using namespace std; | ||
| using namespace gtsam; | ||
|
|
||
| TEST(TrifocalTensor2, transform) { |
| } | ||
|
|
||
| // calculate trifocal tensor | ||
| TrifocalTensor2 T(measurement_u, measurement_v, measurement_w); |
There was a problem hiding this comment.
Change to a "named constructor", static FromBearingMeasurements()
There was a problem hiding this comment.
Have a test for this method, and explain where the ground truth comes from!
|
|
||
| // estimate measurement of a robot from the measurements of the other two | ||
| // robots | ||
| for (unsigned int i = 0; i < measurement_u.size(); i++) { |
| // robots | ||
| for (unsigned int i = 0; i < measurement_u.size(); i++) { | ||
| const Rot2 actual_measurement_u = | ||
| T.transform(measurement_v[i], measurement_w[i]); |
There was a problem hiding this comment.
comment that this is important and is being tested
|
|
||
| // 2D landmarks | ||
| vector<Point2> landmarks; | ||
| landmarks.push_back(Point2(2.0, 0.5)); |
|
|
||
| // 2D landmarks | ||
| vector<Point2> landmarks; | ||
| landmarks.push_back(Point2(2.0, 0.5)); |
|
|
||
| Matrix2 actual_trifocal_tensor_mat0 = T.mat1(); | ||
|
|
||
| Matrix2 exp_trifocal_tensor_mat0; |
There was a problem hiding this comment.
Annotate this with //regression
|
Oh, and, BTW, CI seems to fail. Please do "make check" before doing a push to gtsam repo. As an aside, every push triggers CI, so please don't push every commit - push once you both are satisfied with changes. A development like this might be better done in a fork |
|
@Hal-Zhaodong-Yang do you intend to continue working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
TrifocalTensor2.[h|cpp], which declare and define planar trifocal tensor classTrifocalTensor2.TrifocalTensor2constructors from bearing measurements and bearing measurements expressed in projective coordinates.transformto find a measurement in the first view using measurements from second and third views.testTrifocalTensor2.cpp, which tests the constructed planar trifocal tensor.transformmethod by comparing a set of ground-true bearing measurements with an estimated bearing measurements.