Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Fixes for kick parameter optimization #211

Merged
merged 10 commits into from
Feb 27, 2021

Conversation

timonegk
Copy link
Member

Proposed changes

This adds some fixes used for the kick parameter optimization:

  • remove the rest of tf and instead calculate base_footprint ourselves by just using the mean y value of both feet (what do you think, is that a valid assumption?)
  • improve the usage of foot distance parameter (it is now the foot distance during the kick only, the robot returns to its initial position after the kick)
  • remove bio_ik from cmakelists (see URDF not parsable from python wrapper when bio_ik is find_package'd TAMS-Group/bio_ik#29)
  • add a first set of learned parameters

Necessary checks

  • Run catkin build
  • Write documentation
  • Create issues for future work
  • Test on your machine
  • Test on the robot in simulation
  • Put the PR on our Project board

@timonegk timonegk force-pushed the fix/kick_parameter_optimization branch from 3b6d956 to 2a854bd Compare February 25, 2021 15:39
@timonegk timonegk force-pushed the fix/kick_parameter_optimization branch from 2a854bd to 45b8851 Compare February 25, 2021 16:05
Copy link
Member

@jgueldenstein jgueldenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working in simulation

@jgueldenstein jgueldenstein merged commit 86a0531 into master Feb 27, 2021
@jgueldenstein jgueldenstein deleted the fix/kick_parameter_optimization branch February 27, 2021 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants