Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRP System Ordering #16198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mnmaita
Copy link
Member

@mnmaita mnmaita commented Nov 1, 2024

Objective

Solution

  • Added a new RemoteSystem SystemSet for the BRP systems.
  • Changed the schedule on which these systems run from Update to Last.

Testing

  • I did not test these changes and would appreciate a hand in doing so. I assume it would be good to test that you can order against these systems easily now.

Migration Guide

  • process_remote_requests, process_ongoing_watching_requests and remove_closed_watching_requests now run in the Last schedule. Make sure you use RemoteSystem SystemSet in case you need to order your systems against them.

@BenjaminBrienen BenjaminBrienen added A-Networking Sending data between clients, servers and machines D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 1, 2024
@MiniaczQ
Copy link
Contributor

MiniaczQ commented Nov 3, 2024

I mentioned it in the issue, but I'd consider adding a custom schedule for this, to ensure BRP-unaware users don't mix their systems with BRP systems.
In that case a system set seems pretty unnecessary, at least for the current system complexity

@mockersf mockersf added this to the 0.15 milestone Nov 3, 2024
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No preference from me between Last or its own schedule, both seems fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Networking Sending data between clients, servers and machines D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System ordering around BRP (Bevy Remote Protocol)
4 participants