Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] no_std Option for bevy_tasks #15362

Closed
wants to merge 36 commits into from
Closed

[DRAFT] no_std Option for bevy_tasks #15362

wants to merge 36 commits into from

Conversation

bushrat011899
Copy link
Contributor

@bushrat011899 bushrat011899 commented Sep 22, 2024 •
edited
Loading

Objective

  • Allows using bevy_tasks in no_std contexts

Solution

  • Created custom async_executor based on existing reference implementation but using spin sync primitives, allowing no_std usage.
  • Created an alternative TaskPool using a single global Executor

Testing

  • TBA

Notes

  • Once this is done, only bevy_ecs needs work to permit a minimal no_std Bevy application, as bevy_app is trivially no_std once these two crates are.
  • Currently draft as I am not happy with the Sync requirements required in a no_std context. Also, I'm waiting for the lints in Add core and alloc over std Lints #15281 to be merged, as this work is based off of some of those changes (hence the absurdly high change count)
  • Creating the draft now so anyone else interested in this work may comment (in support or to critique!)

bushrat011899 and others added 30 commits September 18, 2024 15:36
@bushrat011899
Add core and alloc over std Lints
a939e93
@bushrat011899
Fixing issues raised by CI
120e9e0
@bushrat011899
Bump MSRV
abb01eb 
This is due to `Error` in `core`
@bushrat011899
Responding to CI issues
864631f
@bushrat011899
Switch define_label macro to std instead of alloc
145ab01 
Cannot rely on call-sites having `extern crate alloc;`. Perhaps `bevy_ecs` could re-export `Box` for this macro, but `std` is fine for now.
@bushrat011899
Re-export Box to satisfy lint
8a99654
@bushrat011899
Fixed doctests
9e4c516
@bushrat011899
Fixed compile check CI
273cd3a
@bushrat011899
Fixed audio patch and formatting
6960fd1
@bushrat011899
Remove std uses that clippy missed
389310a
@bushrat011899
Fixed typo in find-and-replace
46aa899
@bushrat011899
Merge remote-tracking branch 'upstream/main' into UseCoreOrAlloc
f3c95da
@bushrat011899
Respond to lint in CI
ecc8d33
@bushrat011899
One more std::f32 crushed
5c7fa79
@bushrat011899
Forgot to check examples for those pesky std::f32's
270a49f
@bushrat011899
Allow examples to use the std crate
50e34bd
@bushrat011899
Remove workspace lints from root crate
a6780ba 
We wish to use different lints for the examples, and `cargo` currently doesn't support overriding workspace lints within a crate. As a workaround, all workspace lints are duplicated for the root crate to allow it to specifically allow the standard library.
@bushrat011899
Added comment to Cargo.toml
e28ff2a 
Explains the requirement for duplicating the lints as a form of workspace overrides
@bushrat011899
Merge remote-tracking branch 'upstream/main' into UseCoreOrAlloc
f62b660
@bushrat011899
CI issues from merge
6bbca4e
@bushrat011899 @mockersf
Fixed instances of redundant braces in use statements
cdbc80a 
Co-Authored-By: François Mockers <[email protected]>
@bushrat011899 @mockersf
Re-merge std imports
fff160e 
Co-Authored-By: François Mockers <[email protected]>
@bushrat011899 @mockersf
Revert change in tests as it is not required
4704134 
Co-Authored-By: François Mockers <[email protected]>
@bushrat011899
Merge remote-tracking branch 'upstream/main' into UseCoreOrAlloc
a9e1664
@bushrat011899
Merge remote-tracking branch 'upstream/main' into UseCoreOrAlloc
12b5c66
@bushrat011899
Merge remote-tracking branch 'upstream/main' into UseCoreOrAlloc
e7efe08
@bushrat011899
Remove double std's
b89e0d1
@bushrat011899
Reverted to std for documentation
7a2b7a5 
However, `bevy_ptr` and `bevy_utils` must still link to `core` and `alloc` due to the possibility of being `no_std` based on feature gating.
@bushrat011899
Merge remote-tracking branch 'upstream/main' into UseCoreOrAlloc
de8b0d6
@bushrat011899
Merge remote-tracking branch 'upstream/main' into UseCoreOrAlloc
8e453c7
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Tasks Tools for parallel and async work X-Controversial There is active debate or serious implications around merging this PR S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Sep 22, 2024
@bushrat011899 bushrat011899 force-pushed the NoSTDBevyTasks branch 4 times, most recently from 47dcef8 to 2f345b3 Compare September 23, 2024 10:00
@bushrat011899 bushrat011899 mentioned this pull request Sep 24, 2024
Merged
@bushrat011899 bushrat011899 force-pushed the NoSTDBevyTasks branch 2 times, most recently from ff778c1 to 032bbde Compare September 25, 2024 23:02
@bushrat011899
Copy link
Contributor Author

Closed in favour of #15464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Tasks Tools for parallel and async work C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bushrat011899 @alice-i-cecile