Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/DEVSU-2384-permission-storage-improvement #381

Merged
merged 26 commits into from
Oct 3, 2024

Conversation

Nithriel
Copy link
Contributor

Improvement:

  • Improve user group handling

@Nithriel Nithriel self-assigned this Aug 28, 2024

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (02de261) to head (e5e8de5).

Files with missing lines Patch % Lines
app/routes/user/member.js 66.66% 1 Missing and 1 partial ⚠️
app/middleware/group.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
- Coverage    76.88%   76.83%   -0.05%     
===========================================
  Files          172      171       -1     
  Lines         5840     5798      -42     
  Branches       696      699       +3     
===========================================
- Hits          4490     4455      -35     
+ Misses        1275     1266       -9     
- Partials        75       77       +2     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ithub.com:bcgsc/pori_ipr_api into feature/DEVSU-2384-permission-storage-improvement

This comment has been minimized.

@Nithriel Nithriel requested a review from elewis2 October 1, 2024 21:05

This comment has been minimized.

@elewis2 elewis2 merged commit 2209cb1 into develop Oct 3, 2024
6 checks passed
Copy link

github-actions bot commented Oct 3, 2024

Unit Test Results

    1 files  ±0    60 suites  ±0   2m 36s ⏱️ -6s
549 tests  - 6  549 ✔️  - 6  0 💤 ±0  0 ❌ ±0 
546 runs   - 6  546 ✔️  - 6  0 💤 ±0  0 ❌ ±0 

Results for commit 2209cb1. ± Comparison against base commit 02de261.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants