Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feature/DEVSU-2384-permission-storage-improvement" #386

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Oct 3, 2024

Reverts #381

This comment has been minimized.

@elewis2
Copy link
Collaborator Author

elewis2 commented Oct 3, 2024

Migrations error when run against db

@elewis2 elewis2 merged commit 3123995 into develop Oct 3, 2024
6 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.08108% with 14 lines in your changes missing coverage. Please review.

Project coverage is 76.88%. Comparing base (2209cb1) to head (cd9869d).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
app/routes/user/group.js 70.83% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #386      +/-   ##
===========================================
+ Coverage    76.83%   76.88%   +0.04%     
===========================================
  Files          171      172       +1     
  Lines         5798     5840      +42     
  Branches       699      696       -3     
===========================================
+ Hits          4455     4490      +35     
- Misses        1266     1275       +9     
+ Partials        77       75       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 4, 2024

Unit Test Results

    1 files  ±0    60 suites  ±0   2m 39s ⏱️ +3s
555 tests +6  555 ✔️ +6  0 💤 ±0  0 ❌ ±0 
552 runs  +6  552 ✔️ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 3123995. ± Comparison against base commit 2209cb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants