Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_behavior_path_start_planner_module): move planner_data to method parameter #9788

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

This PR refactors the pull-out planner interfaces by removing the planner_data member variable from the PullOutPlannerBase class and passing it as a method parameter instead.

This change:

  • Removes setPlannerData() method from PullOutPlannerBase
  • Updates plan() method signature across all pull-out planner implementations to accept planner_data
  • Improves testability

The changes maintain the same functionality while making the code more maintainable.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 25, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant