Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable to copy all information in pickup based pointcloud downsampler #9686

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Dec 18, 2024

Description

Previously pickup-based downsampler, which is used in the default downsampler for the perception input, only copies x,y,z attribute and do not copy other one like intensity. This leads to cause some perception issue.

This PR fix this problem by copying all attributes.

Related links

How was this PR tested?

Just build and tested with sample bag file(WIP).

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test labels Dec 18, 2024
@YoshiRi YoshiRi added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test labels Dec 18, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.80%. Comparing base (6524f38) to head (04d8987).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9686      +/-   ##
==========================================
- Coverage   29.80%   29.80%   -0.01%     
==========================================
  Files        1444     1445       +1     
  Lines      108610   108640      +30     
  Branches    42670    42672       +2     
==========================================
+ Hits        32374    32376       +2     
- Misses      73058    73087      +29     
+ Partials     3178     3177       -1     
Flag Coverage Δ *Carryforward flag
differential 24.02% <100.00%> (?)
total 29.80% <ø> (-0.01%) ⬇️ Carriedforward from 6524f38

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YoshiRi YoshiRi merged commit 3b56716 into main Dec 18, 2024
45 of 50 checks passed
@YoshiRi YoshiRi deleted the feat/enable_copy_intensity_in_downsample_filter branch December 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants