feat(pid_longitudinal_controller): remove trans/rot deviation validation since the control_validator has the same feature #9675
+1
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion since the control_validator has the same feature Signed-off-by: Takayuki Murooka <[email protected]>
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
takayuki5168
requested review from
soblin,
TakaHoribe and
yuki-takagi-66
as code owners
takayuki5168
requested review from
kyoichi-sugahara
and removed request for
kyoichi-sugahara
takayuki5168
added
the
tag:run-build-and-test-differential
yuki-takagi-66
approved these changes
Dec 18, 2024
Signed-off-by: Takayuki Murooka <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9675 +/- ##
==========================================
- Coverage 29.88% 29.86% -0.02%
==========================================
Files 1440 1440
Lines 108347 108334 -13
Branches 42467 42450 -17
==========================================
- Hits 32376 32351 -25
- Misses 72730 72743 +13
+ Partials 3241 3240 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, several nodes have a translational/rotational deviation checker.
Among them, the control_validator should be responsible for it, so I removed it from the pid_longiudinal_controller.
Related links
How was this PR tested?
psim worked.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.