Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_behavior_path_start_planner_module): add unit tests for shift shift pull out planner #9661

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

  1. Added test environment for autoware_behavior_path_start_planner_module
  2. Added TestShiftPullOut as a friend class to ShiftPullOut class
    • Enabled access to private members from the test class

Related links

Parent Issue:

  • Link

How was this PR tested?

run colcon test with following command

colcon test --event-handlers console_cohesion+ --packages-select autoware_behavior_path_start_planner_module

get the success result

1: [----------] 1 test from TestShiftPullOut
1: [ RUN      ] TestShiftPullOut.GenerateValidShiftPullOutPath
1: [INFO] [route_handler]: getMainLanelets: lanelet_sequence = [ids: 4618 4635 ] (getMainLanelets:2025)
1: primitive: 4618
1: preferred_primitive id : 4618
1: primitive: 4635
1: primitive: 7787
1: preferred_primitive id : 4635
1: [WARN] [behavior_path_planner.path_shifter]: Acc limit is too small to be applied. Tj: -0.631609, Ta: 5.837664, j: -0.237489, a_max: 0.341422, acc_limit: 0.150000 (calc_base_lengths:354)
1: [       OK ] TestShiftPullOut.GenerateValidShiftPullOutPath (281 ms)
1: [----------] 1 test from TestShiftPullOut (281 ms total)

Notes for reviewers

This PR should be merged before this PR.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 16, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.99%. Comparing base (a85c67b) to head (9bd760e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...t_manager/autoware_planning_test_manager_utils.hpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9661      +/-   ##
==========================================
+ Coverage   29.80%   29.99%   +0.18%     
==========================================
  Files        1443     1447       +4     
  Lines      108588   108594       +6     
  Branches    42652    42643       -9     
==========================================
+ Hits        32369    32569     +200     
+ Misses      73040    72824     -216     
- Partials     3179     3201      +22     
Flag Coverage Δ *Carryforward flag
differential 31.03% <66.66%> (?)
total 29.81% <ø> (+<0.01%) ⬆️ Carriedforward from a85c67b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants